Skip to content

Conversation

@janjust
Copy link
Contributor

@janjust janjust commented Oct 25, 2023

bot:notacherrypick

Signed-off-by: Tomislav Janjusic <[email protected]>
@github-actions github-actions bot added this to the v5.0.0 milestone Oct 25, 2023
@github-actions
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

753de59: update LICENSE

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@janjust janjust changed the title V5.0.x release version V5.0.x update readme for upcoming release doc Oct 25, 2023
@janjust janjust changed the title V5.0.x update readme for upcoming release doc V5.0.x update README, LICENSE Oct 25, 2023
@janjust janjust requested review from lrbison and wenduwan October 25, 2023 21:30
@awlauria
Copy link
Contributor

the license changes should probs go back to main. thanks!

LICENSE Outdated
Copyright (c) 2013-2023 Research Organization for Information Science (RIST).
All rights reserved.
Copyright (c) 2017-2021 Amazon.com, Inc. or its affiliates. All Rights
Copyright (c) Amazon.com, Inc. or its affiliates. All Rights
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ummm...why are there no dates associated with Amazon any more? And did HPE, Fujitsu, Sandia, and Google actually submit changes this year?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed #9039 by bumping all '21 to '23. Having said that, v5.0 was in development well over 2 years I don't see how I can track down who all actually contributed. I could leave it out apart from the key contributors that I'm aware of and let others complain. I figured this was safer. As far as Amazon, they're going to a dateless format and asked me to remove the dates.
I see that Nanuk is 2021 - does it need an end date or update to '23?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that Nanuk is 2021 - does it need an end date or update to '23?

Doesn't really matter - I have no intentions of enforcing anything anyway

As far as Amazon, they're going to a dateless format and asked me to remove the dates.

Well, based on what our lawyers told us when we started the project, a copyright without date is legally meaningless. You cannot claim a time-unlimited copyright - no such legal thing. Don't know if it invalidates the entire license, or if it just means Amazon has no legal rights. You should check with your own lawyers to see before releasing it that way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spoken to amazon guys, readding the date is fine too, so for consistency I'll do revert their dates.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhc54 done

@janjust janjust changed the title V5.0.x update README, LICENSE V5.0.x update LICENSE Oct 25, 2023
Copy link
Contributor

@wenduwan wenduwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Tommy!

@janjust janjust merged commit 2c4740d into open-mpi:v5.0.x Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants