Pr/rocm ldflags libs v5.0 #12047
Merged
Pr/rocm ldflags libs v5.0 #12047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch to using ubuntu 22.04 base image - set LD_LIBRARY_PATH before compiling Open MPI to avoid a link error with ompi_info - remove the cleanup step Signed-off-by: Edgar Gabriel <[email protected]> (cherry picked from commit 2a93bda)
update configure and compile logic to avoid adding hip libraries to the generic Open MPI LIBS. Signed-off-by: Edgar Gabriel <[email protected]> (cherry picked from commit 0254552)
jsquyres
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not add the rocm_libs to the generic LIBS, they will be used to link the rocm accelerator component only.
Fixes issue #11971
This pr brings over the commits of pr #12026