Skip to content

opal/accelerator: allow 0 size copies - v5.0.x #12241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024
Merged

opal/accelerator: allow 0 size copies - v5.0.x #12241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions opal/mca/accelerator/cuda/accelerator_cuda.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,9 +364,12 @@ static int accelerator_cuda_memcpy_async(int dest_dev_id, int src_dev_id, void *
return delayed_init;
}

if (NULL == stream || NULL == dest || NULL == src || size <= 0) {
if (NULL == stream || NULL == dest || NULL == src || size < 0) {
return OPAL_ERR_BAD_PARAM;
}
if (0 == size) {
return OPAL_SUCCESS;
}

result = cuMemcpyAsync((CUdeviceptr) dest, (CUdeviceptr) src, size, *(CUstream *)stream->stream);
if (OPAL_UNLIKELY(CUDA_SUCCESS != result)) {
Expand All @@ -387,9 +390,12 @@ static int accelerator_cuda_memcpy(int dest_dev_id, int src_dev_id, void *dest,
return delayed_init;
}

if (NULL == dest || NULL == src || size <= 0) {
if (NULL == dest || NULL == src || size < 0) {
return OPAL_ERR_BAD_PARAM;
}
if (0 == size) {
return OPAL_SUCCESS;
}

/* Async copy then synchronize is the default behavior as some applications
* cannot utilize synchronous copies. In addition, host memory does not need
Expand Down
10 changes: 8 additions & 2 deletions opal/mca/accelerator/rocm/accelerator_rocm_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,12 @@ static int mca_accelerator_rocm_memcpy_async(int dest_dev_id, int src_dev_id, vo
opal_accelerator_transfer_type_t type)
{
if (NULL == stream || NULL == src ||
NULL == dest || size <= 0) {
NULL == dest || size < 0) {
return OPAL_ERR_BAD_PARAM;
}
if (0 == size) {
return OPAL_SUCCESS;
}

hipError_t err = hipMemcpyAsync(dest, src, size, hipMemcpyDefault,
*((hipStream_t *)stream->stream));
Expand All @@ -275,9 +278,12 @@ static int mca_accelerator_rocm_memcpy(int dest_dev_id, int src_dev_id, void *de
{
hipError_t err;

if (NULL == src || NULL == dest || size <=0) {
if (NULL == src || NULL == dest || size < 0) {
return OPAL_ERR_BAD_PARAM;
}
if (0 == size) {
return OPAL_SUCCESS;
}

if (type == MCA_ACCELERATOR_TRANSFER_DTOH && size <= opal_accelerator_rocm_memcpyD2H_limit) {
memcpy(dest, src, size);
Expand Down