Properly initialize mca_rcache_base_module_t members [v5.0.x] #12261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All but the udreg rcache module did not properly initialize the `lock` member in the mca_rcache_base_module_t parent, which triggers an assert on Mac OSX when trying to take that lock. Signed-off-by: Joseph Schuchart <[email protected]> (cherry picked from commit f81fc3e)
devreal
changed the title
|
@devreal I realize the main commit was merged today - do you think if it's a good idea to hold on backport for a day so we can get main branch test coverage, e.g. mtt? |
|
Sure, no rush on this one 👍 |
|
@bosilca Could you please review the backport? |
bosilca
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All but the udreg rcache module did not properly initialize the
lockmember in the mca_rcache_base_module_t parent, which triggers an assert on Mac OSX when trying to take that lock.Cherry-pick of #12248 to v5.0.x
Signed-off-by: Joseph Schuchart [email protected]