[v5.0.x] Minor fixes: comment correction and spelling "Registration" #12287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will hold back until 5.0.2 release. |
|
@lrbison Could you please fix the conflict? |
added 2 commits
February 7, 2024 16:21
Previously the comment suggested 0-byte sends were skipped, but this was no longer accurate. Update the comment to reflect the implementation. Signed-off-by: Luke Robison <[email protected]> (cherry picked from commit 28732cb)
Update some comments and an enum value which where missing an R. Signed-off-by: Luke Robison <[email protected]> (cherry picked from commit 0da5eec)
wenduwan
force-pushed
the
minor_fixes_v5
branch
from
2c8017c to
1699dbb
Compare
|
I clicked rebase branch. |
wenduwan
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12281.
I'm primarily motivated to backport the enum rename, so we don't have to edit any other backports which use the enum.