[v5.0.x] Backport alltoallv fixes #12347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous change c1a98f1 should have checked for total data size in bytes instead of count. This patch fixes that. Signed-off-by: Wenduo Wang <[email protected]> (cherry picked from commit a7b4d3e)
As per MPI specification the amount of data sent must be equal to the amount of data received for each communication pair, and therefore both count and datatype size should be accounted for to determine if the data is 0-byte and therefore skippable. Signed-off-by: Wenduo Wang <[email protected]> (cherry picked from commit a3a4787)
This is a followup to open-mpi#12198. The previous change introduced a bug that skips send and recv if either datatype is of 0-size. This is wrong because MPI_Alltoallv allows each process to use a unique datatype. The correct solution is to check send and recv datatype size separately and skip send and recv accordingly. This includes the pairwise algorithm which should not send/recv 0-count data. Signed-off-by: Wenduo Wang <[email protected]> (cherry picked from commit f242d0d)
This is a followup to open-mpi#12198. The previous change introduced a bug that skips send and recv if either datatype is of 0-size. This is wrong because MPI_Ialltoallv allows each process to use a unique datatype. The correct solution is to check send and recv datatype size separately and skip send and recv accordingly. Signed-off-by: Wenduo Wang <[email protected]> (cherry picked from commit 737eefd)
janjust
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch series for (i)alltoallv