Find libcuda.so automatically if --with-cuda-lib is not passed. #12382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finding CUDA libraries without having to specify both --with-cuda and --with-cuda-lib was requested in github issue open-mpi#12264 Signed-off-by: Nick Sarkauskas <[email protected]> (cherry picked from commit cad3d9a)
wenduwan
approved these changes
Feb 28, 2024
jsquyres
requested changes
Feb 28, 2024
jsquyres
reviewed
Feb 28, 2024
|
Apologies for not catching this and posting on the original master PR. |
I have opened a PR to the main branch here: #12385 |
…y find libcuda.so Also, redirect the find output to /dev/null to avoid unnecessary output Signed-off-by: Nick Sarkauskas <[email protected]> (cherry picked from commit d57ab5b)
janjust
approved these changes
Mar 5, 2024
|
@jsquyres done - it has the doc change and the does NOT redirect to a hardcoded path if the user directory does not exist. |
jsquyres
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding CUDA libraries without having to specify both --with-cuda and --with-cuda-lib was requested in github issue
#12264
Signed-off-by: Nick Sarkauskas [email protected]
(cherry picked from commit cad3d9a)