Skip to content

v5.0.x: Fix compiler warning #12405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024
Merged

v5.0.x: Fix compiler warning #12405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ompi/communicator/comm_cid.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,8 @@ static int ompi_comm_ext_cid_new_block (ompi_communicator_t *newcomm, ompi_commu
opal_process_name_t *name_array = NULL;
char *tag = NULL;
size_t proc_count;
size_t cid_base;
size_t cid_base = 0;
bool cid_base_set = false;
int rc, leader_rank;
int ret = OMPI_SUCCESS;
pmix_proc_t *procs = NULL;
Expand Down Expand Up @@ -383,6 +384,7 @@ static int ompi_comm_ext_cid_new_block (ompi_communicator_t *newcomm, ompi_commu
ret = opal_pmix_convert_status(rc);
goto fn_exit;
}
cid_base_set = true;
break;
}
}
Expand All @@ -393,6 +395,12 @@ static int ompi_comm_ext_cid_new_block (ompi_communicator_t *newcomm, ompi_commu
goto fn_exit;
}

if (!cid_base_set) {
opal_show_help("help-comm.txt", "cid-base-not-set", true);
ret = OMPI_ERROR;
goto fn_exit;
}

ompi_comm_extended_cid_block_initialize (new_block, cid_base, 0, 0);

fn_exit:
Expand Down
9 changes: 9 additions & 0 deletions ompi/communicator/help-comm.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,12 @@ in a call to MPI_Comm_split_type between peers in the communicator.
[unexpected-split-type]
Detected an unexpected split type in a call to MPI_Comm_split_type.
split_type: %s (%d)
[cid-base-not-set]
An internal error has occurred when creating a new communicator. This
should probably never happen:

* cid_base is not set. Either nresults
is zero or no returned info matches PMIX_GROUP_CONTEXT_ID.

Please contact the Open MPI developer community with this message and
a small example code that reproduces the issue.