Skip to content

Conversation

@alex--m
Copy link
Contributor

@alex--m alex--m commented Mar 21, 2024

See #12360

@github-actions github-actions bot added this to the v5.0.3 milestone Mar 21, 2024
@github-actions
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

fda165f: oshmem/shmem/c: include missing headers

  • check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@janjust
Copy link
Contributor

janjust commented Mar 21, 2024

@alex--m forgot the cherry-pick message (-x)

@alex--m alex--m force-pushed the topic/oshmem_c_fix_v5.0.x branch from fda165f to e57fff5 Compare March 21, 2024 16:06
@github-actions
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

e57fff5: oshmem/shmem/c: include missing headers

  • check_cherry_pick: contains a cherry pick message that refers to a commit that exists, but is in an as-yet unmerged pull request: fda165f

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@alex--m
Copy link
Contributor Author

alex--m commented Mar 21, 2024

@janjust does this pre-commit error means it depends on the merge to main branch? or is there something else I should do?

@janjust
Copy link
Contributor

janjust commented Mar 21, 2024

Yes, but I thought I just merged it

@janjust
Copy link
Contributor

janjust commented Mar 21, 2024

This is the main commit: d737f00
But the one here says:
cherry picked from commit fda165f

Did you cherry-pick from your branch? Maybe that's why

@alex--m
Copy link
Contributor Author

alex--m commented Mar 21, 2024

You're probably right, fixing...

Signed-off-by: Alex Margolin <[email protected]>
(cherry picked from commit d737f00)
@alex--m alex--m force-pushed the topic/oshmem_c_fix_v5.0.x branch from e57fff5 to caa86d0 Compare March 21, 2024 16:23
@wenduwan wenduwan merged commit f9efaa8 into open-mpi:v5.0.x Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants