configury: harden IGNORE_TKR check #12707
Closed
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 5660c69: configury: harden IGNORE_TKR check
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
ggouaillardet
force-pushed
the
topic/v4.1.x/nvfortran_ignore_tkr
branch
from
5660c69 to
194d8a5
Compare
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 194d8a5: configury: harden IGNORE_TKR check
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
|
:bot:retest |
|
bot:aws:retest |
NVIDIA HPC Compiler (e.g. nvfortran) incorrectly selected the GCC style pragmas to support IGNORE_TKR. Harden the test by mimicking exactly the mpi f08 bindings in order to fix that false positive. Thanks Chris Parrot for the report. Refs. open-mpi#11582 Signed-off-by: Gilles Gouaillardet <[email protected]> bot:notacherrypick (back-ported from commit 600df6a)
ggouaillardet
force-pushed
the
topic/v4.1.x/nvfortran_ignore_tkr
branch
from
194d8a5 to
903055c
Compare
|
Odd... I updated the PR to fix not sure why other branches were happy though... |
|
@ggouaillardet is there a reason this PR is still in draft? Is it ready / can we close it? |
|
#12861 (and backports if any) addressed the issue, I am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVIDIA HPC Compiler (e.g. nvfortran) incorrectly selected the GCC style pragmas to support IGNORE_TKR. Harden the test by mimicking exactly the mpi f08 bindings in order to fix that false positive.
Thanks Chris Parrot for the report.
Refs. #11582
Signed-off-by: Gilles Gouaillardet [email protected]
bot:notacherrypick
(back-ported from commit 600df6a)