Skip to content

pml/cm,ob1: pack data from application buffer in successive MPI_Start calls #12797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024
Merged

pml/cm,ob1: pack data from application buffer in successive MPI_Start calls #12797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3226c6c
pml/cm: pack data from application buffer in successive MPI_Start calls
wenduwan Sep 5, 2024
429c7b7
Fix buffered sends for OB1 as well.
bosilca Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ompi/mca/pml/cm/pml_cm_sendreq.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,10 @@ do { \
iov.iov_base = (IOVBASE_TYPE*)sendreq->req_buff; \
max_data = iov.iov_len = sendreq->req_count; \
iov_count = 1; \
opal_convertor_prepare_for_send( &sendreq->req_send.req_base.req_convertor, \
&sendreq->req_send.req_base.req_datatype->super, \
max_data, \
sendreq->req_addr); \
opal_convertor_pack( &sendreq->req_send.req_base.req_convertor, \
&iov, \
&iov_count, \
Expand Down
11 changes: 7 additions & 4 deletions ompi/mca/pml/ob1/pml_ob1_start.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,16 @@ int mca_pml_ob1_start(size_t count, ompi_request_t** requests)
sendreq = (mca_pml_ob1_send_request_t *) request;
requests[i] = request;
} else if (sendreq->req_send.req_bytes_packed != 0) {
size_t offset = 0;
/**
* Reset the convertor in case we're dealing with the original
* request, which when completed do not reset the convertor.
* request, which when completed do not reset the convertor but
* leaves it pointing to the buffered send location, with the
* packed datatype and count.
*/
opal_convertor_set_position (&sendreq->req_send.req_base.req_convertor,
&offset);
opal_convertor_prepare_for_send(&sendreq->req_send.req_base.req_convertor,
&sendreq->req_send.req_base.req_datatype->super,
sendreq->req_send.req_base.req_count,
sendreq->req_send.req_base.req_addr);
}

/* reset the completion flag */
Expand Down
Loading