v5.0.x: Fix OFI build warnings #13269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FI_MR_BASIC (1<<0) and FI_MR_SCALABLE (1<<1) are deprecated since Libfabric 1.5 and the symbols will get removed in future Libfabric 2.x versions. Use the internal mode bits for backward compatibilities without breaking compilation with newer libfabric. Signed-off-by: Shi Jin <[email protected]> (cherry picked from commit 281c6cd)
There should not be any Cray XC systems in production now - which is where the GNI provider nominally functioned. Meanwhile FI_MR_BASIC is deprecated since Libfabric 1.5 and will be droppped in future Libfabric 2.x versions. Remove this special handler for gni provider due to unnecessity and build warnings. Signed-off-by: Shi Jin <[email protected]> (cherry picked from commit 1c67d90)
|
@janjust can you take a look |
janjust
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #13266 to v5.0.x