ofi/btl: CHange default support to 1 & 2 sided ops #13331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, the OFI BTL has defaulted to only supporting one-sided operations (ie, the RDMA OSC component). Howard and I can't think of a current Libfabric provider that has a performance difference when in one-sided vs. both one and two-sided mode, so change the default to support both. This allows users who want to use the OB1 PML to specify `-mca pml ob1` without also having to change the default mode in the BTL. Signed-off-by: Brian Barrett <[email protected]>
shijin-aws
approved these changes
Jul 14, 2025
hppritcha
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, the OFI BTL has defaulted to only supporting one-sided operations (ie, the RDMA OSC component). Howard and I can't think of a current Libfabric provider that has a performance difference when in one-sided vs. both one and two-sided mode, so change the default to support both. This allows users who want to use the OB1 PML to specify
-mca pml ob1without also having to change the default mode in the BTL.