Skip to content

Conversation

@ttm02
Copy link
Contributor

@ttm02 ttm02 commented Aug 15, 2025

These functions are only defined with ENABLE_FT_MPI
Or is a build configuration --without-ft invalid?

@github-actions
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

4f854bd: Fix build error for build configured with --withou...

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@jsquyres
Copy link
Member

@bosilca @abouteiller Can you comment?

These functions are labaled "noft", but yet they're still defined only inside #if OPAL_ENABLE_FT_MPI -- is that right?

@abouteiller
Copy link
Member

abouteiller commented Aug 15, 2025

Configuration --without-ft should be valid, I think the PR will make it compile but fail at runtime, let me double check it.

Copy link
Member

@bosilca bosilca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit. It won't fail at runtime because the FT function cannot be called directly by the user in that case, and because the checks for collective validation ignores the FT functions if FT is disabled).

@abouteiller abouteiller merged commit d723a8d into open-mpi:main Aug 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants