Skip to content

v5.0.x: fortran: fix ompi string c2f where len(fstr) < len(cstr) #13382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2025
Merged

v5.0.x: fortran: fix ompi string c2f where len(fstr) < len(cstr) #13382

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1475489
fortran: fix ompi string c2f where len(fstr) < len(cstr)
jsquyres Aug 26, 2025
cc72cc7
fortran: fix off-by-one string copy error
jsquyres Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ompi/mpi/fortran/base/strings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* Copyright (c) 2010-2018 Cisco Systems, Inc. All rights reserved
* Copyright (c) 2017 Research Organization for Information Science
* and Technology (RIST). All rights reserved.
* Copyright (c) 2025 Jeffrey M. Squyres. All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
Expand Down Expand Up @@ -95,8 +96,19 @@ int ompi_fortran_string_c2f(const char *cstr, char *fstr, int len)
int i;

opal_string_copy(fstr, cstr, len);
for (i = strlen(cstr); i < len; ++i) {
fstr[i] = ' ';

// If len < len(cstr), then opal_string_copy() will have copied a
// trailing \0 into the last position in fstr. This is not what
// Fortran wants; overwrite that \0 with the actual last character
// that will fit into fstr.
if (len <= strlen(cstr)) {
fstr[len - 1] = cstr[len - 1];
} else {
// Otherwise, pad the end of the resulting Fortran string with
// spaces.
for (i = strlen(cstr); i < len; ++i) {
fstr[i] = ' ';
}
}

return OMPI_SUCCESS;
Expand Down
Loading