Replace sprintf with snprintf

ompi/communicator/comm_cid.c

@@ -417,7 +417,7 @@ static int ompi_comm_ext_cid_new_block (ompi_communicator_t *newcomm, ompi_commu
        char msg_string[1024];
         switch (rc) {
         case PMIX_ERR_UNREACH:
-            sprintf(msg_string,"PMIx server unreachable");
+            snprintf(msg_string, sizeof(msg_string), "PMIx server unreachable");
             opal_show_help("help-comm.txt",
                            "MPI function not supported",
                            true,
@@ -427,7 +427,7 @@ static int ompi_comm_ext_cid_new_block (ompi_communicator_t *newcomm, ompi_commu
             rc = MPI_ERR_UNSUPPORTED_OPERATION;
             break;
         case PMIX_ERR_NOT_SUPPORTED:
-            sprintf(msg_string,"PMIx server does not support PMIx Group operations");
+            snprintf(msg_string, sizeof(msg_string), "PMIx server does not support PMIx Group operations");
             opal_show_help("help-comm.txt",
                            "MPI function not supported",
                            true,
@@ -577,7 +577,7 @@ int ompi_comm_nextcid_nb (ompi_communicator_t *newcomm, ompi_communicator_t *com
        functions but the pml does not support these functions so return not supported */
     if (NULL == comm) {
        char msg_string[1024];
-       sprintf(msg_string,"The PML being used - %s - does not support MPI sessions related features",
+       snprintf(msg_string, sizeof(msg_string), "The PML being used - %s - does not support MPI sessions related features",
                mca_pml_base_selected_component.pmlm_version.mca_component_name);
        opal_show_help("help-comm.txt",
                       "MPI function not supported",

ompi/instance/instance.c

@@ -1292,7 +1292,7 @@ static int ompi_instance_group_pmix_pset (ompi_instance_t *instance, const char
             ret = MPI_ERR_ARG; /* pset_name not valid */
             break;
         case PMIX_ERR_UNREACH:
-            sprintf(msg_string,"PMIx server unreachable");
+            snprintf(msg_string, sizeof(msg_string), "PMIx server unreachable");
             opal_show_help("help-comm.txt",
                            "MPI function not supported",
                            true,
@@ -1301,7 +1301,7 @@ static int ompi_instance_group_pmix_pset (ompi_instance_t *instance, const char
             ret = MPI_ERR_UNSUPPORTED_OPERATION;
             break;
         case PMIX_ERR_NOT_SUPPORTED:
-            sprintf(msg_string,"PMIx server does not support PMIX_QUERY_PSET_MEMBERSHIP operation");
+            snprintf(msg_string, sizeof(msg_string), "PMIx server does not support PMIX_QUERY_PSET_MEMBERSHIP operation");
             opal_show_help("help-comm.txt",
                            "MPI function not supported",
                            true,

ompi/mca/coll/ftagree/coll_ftagree_earlyreturning.c

@@ -497,7 +497,7 @@ static void era_debug_print_group(int lvl, ompi_group_t *group, ompi_communicato
     }
     s = 128 + n * 16;
     str = (char*)malloc(s);
-    sprintf(str, "Group of size %d. Ranks in %d.%d: (", n, comm->c_index, comm->c_epoch);
+    snprintf(str, s, "Group of size %d. Ranks in %d.%d: (", n, comm->c_index, comm->c_epoch);
     p = strlen(str);
     for(i = 0; i < n; i++) {
         snprintf(str + p, s - p, "%d%s", gra[i], i==n-1 ? "" : ", ");
@@ -2283,7 +2283,7 @@ static void send_msg(ompi_communicator_t *comm,
                     b++;
                 } while(w < 256);
                 if( strlen(strbytes) >= 252 ) {
-                    sprintf(strbytes + 252, "...");
+                    snprintf(strbytes + 252, 256 - 252, "...");
                 }
 
                 OPAL_OUTPUT_VERBOSE((30, ompi_ftmpi_output_handle,

ompi/mca/coll/ucc/coll_ucc_module.c

@@ -312,22 +312,22 @@ static int mca_coll_ucc_init_ctx(ompi_communicator_t* comm)
         goto cleanup_lib;
     }
 
-    sprintf(str_buf, "%u", ompi_proc_world_size());
+    snprintf(str_buf, sizeof(str_buf), "%u", ompi_proc_world_size());
     if (UCC_OK != ucc_context_config_modify(ctx_config, NULL, "ESTIMATED_NUM_EPS",
                                             str_buf)) {
         UCC_ERROR("UCC context config modify failed for estimated_num_eps");
         goto cleanup_lib;
     }
 
-    sprintf(str_buf, "%u", opal_process_info.num_local_peers + 1);
+    snprintf(str_buf, sizeof(str_buf), "%u", opal_process_info.num_local_peers + 1);
     if (UCC_OK != ucc_context_config_modify(ctx_config, NULL, "ESTIMATED_NUM_PPN",
                                             str_buf)) {
         UCC_ERROR("UCC context config modify failed for estimated_num_eps");
         goto cleanup_lib;
     }
 
     if (ucc_api_major > 1 || (ucc_api_major == 1 && ucc_api_minor >= 6)) {
-        sprintf(str_buf, "%u", opal_process_info.my_local_rank);
+        snprintf(str_buf, sizeof(str_buf), "%u", opal_process_info.my_local_rank);
         if (UCC_OK != ucc_context_config_modify(ctx_config, NULL, "NODE_LOCAL_ID",
                                                 str_buf)) {
             UCC_ERROR("UCC context config modify failed for node_local_id");

ompi/mca/common/monitoring/common_monitoring_coll.c

@@ -70,15 +70,16 @@ static inline void mca_common_monitoring_coll_cache(mca_monitoring_coll_data_t*d
         assert( 0 < size );
         /* Allocate enough space for list (add 1 to keep the final '\0' if already exact size) */
         max_length = snprintf(NULL, 0, "%d,", world_size - 1) + 1;
-        tmp_procs = malloc((1 + max_length * size) * sizeof(char));
+        int bufsize = (1 + max_length * size) * sizeof(char);
+        tmp_procs = malloc(bufsize);
         if( NULL == tmp_procs ) {
             OPAL_MONITORING_PRINT_ERR("Cannot allocate memory for caching proc list.");
         } else {
             tmp_procs[0] = '\0';
             /* Build procs list */
             for(i = 0; i < size; ++i) {
                 if( OPAL_SUCCESS == mca_common_monitoring_get_world_rank(i, data->p_comm->c_remote_group, &world_rank) )
-                    pos += sprintf(&tmp_procs[pos], "%d,", world_rank);
+                    pos += snprintf(&tmp_procs[pos], bufsize - pos, "%d,", world_rank);
             }
             tmp_procs[pos - 1] = '\0'; /* Remove final coma */
             data->procs = realloc(tmp_procs, pos * sizeof(char)); /* Adjust to size required */

ompi/mca/hook/comm_method/hook_comm_method_fns.c

@@ -325,9 +325,9 @@ abbreviate_list_into_string(char *str, int max, int *list, int nlist)
                     strcpy(&str[strlen(str)], ", ");
                 }
                 if (lo != hi) {
-                    sprintf(&str[strlen(str)], "%d - %d", lo, hi);
+                    snprintf(&str[strlen(str)], max - strlen(str), "%d - %d", lo, hi);
                 } else {
-                    sprintf(&str[strlen(str)], "%d", lo);
+                    snprintf(&str[strlen(str)], max - strlen(str), "%d", lo);
                 }
             }
 /*
@@ -352,9 +352,9 @@ abbreviate_list_into_string(char *str, int max, int *list, int nlist)
             strcpy(&str[strlen(str)], ", ");
         }
         if (lo != hi) {
-            sprintf(&str[strlen(str)], "%d - %d", lo, hi);
+            snprintf(&str[strlen(str)], max - strlen(str), "%d - %d", lo, hi);
         } else {
-            sprintf(&str[strlen(str)], "%d", lo);
+            snprintf(&str[strlen(str)], max - strlen(str), "%d", lo);
         }
     }
 }
@@ -460,7 +460,7 @@ ompi_report_comm_methods(int called_from_location)
 
         len = strlen(opal_process_info.nodename) + 100;
         hoststring  = malloc(len + 1);
-        sprintf(hoststring, "Host %d [%s] ranks ",
+        snprintf(hoststring, len + 1, "Host %d [%s] ranks ",
             myleaderrank, opal_process_info.nodename);
 
         abbreviate_list_into_string(&hoststring[strlen(hoststring)],
@@ -642,7 +642,7 @@ ompi_report_comm_methods(int called_from_location)
 // 2: 2d table
         if (nleaderranks <= max2Dprottable) {
             char *str, *p;
-            int tmp, per, has_ucx_transport;
+            int tmp, per, has_ucx_transport, bufsize;
             int strlens[NUM_COMM_METHODS];
 
             // characters per entry in the 2d table, must be large enough
@@ -668,11 +668,11 @@ ompi_report_comm_methods(int called_from_location)
                     if (tmp+1 > per) { per = tmp+1; }
                 }
             }
-
-            str = malloc(nleaderranks * per + 1);
+            bufsize = nleaderranks * per + 1;
+            str = malloc(bufsize);
             p = str;
             for (i=0; i<nleaderranks; ++i) {
-                sprintf(p, "%d", i);
+                snprintf(p, bufsize - (p - str), "%d", i);
                 for (j=(int)strlen(p); j<per; ++j) {
                     p[j] = ' ';
                 }
@@ -698,12 +698,12 @@ ompi_report_comm_methods(int called_from_location)
                 for (k=0; k<nleaderranks; ++k) {
                     char *method_string;
                     char ucx_label[20];
-                    
+
                     method_string = comm_method_to_string(method[i * nleaderranks + k]);
                     if (0 == strncmp(method_string, UCX_TAG, strlen(UCX_TAG))) {
                         n = lookup_string_in_conversion_struct(&comm_method_string_conversion,
                                                                method_string);
-                        sprintf(ucx_label, "ucx[%3d]", n);
+                        snprintf(ucx_label, sizeof(ucx_label), "ucx[%3d]", n);
                         strcat(p, ucx_label);
                         methods_used[n / 8] |= (1 << (n % 8));
                         has_ucx_transport = 1;
@@ -755,7 +755,7 @@ ompi_report_comm_methods(int called_from_location)
         }
         else if (nleaderranks <= max2D1Cprottable) {
             char *str, *p;
-            int tmp, per, done;
+            int tmp, per, done, bufsize;
             char char_code[NUM_COMM_METHODS], next_char;
             int method_count[NUM_COMM_METHODS];
 
@@ -798,12 +798,13 @@ ompi_report_comm_methods(int called_from_location)
                 }
             }
 
-            str = malloc(per + 32 + nleaderranks * 2 + 1);
+            bufsize = nleaderranks * (per + 1) + 1;
+            str = malloc(bufsize);
             p = str;
-            sprintf(p, "0 1 2 3 ");
+            snprintf(p, bufsize,  "0 1 2 3 ");
             p += 8;
             for (i=4; i<nleaderranks; i+=4) {
-                sprintf(p, "%d", i);
+                snprintf(p, bufsize - (p - str), "%d", i);
                 for (j=(int)strlen(p); j<8; ++j) {
                     p[j] = ' ';
                 }
@@ -974,13 +975,14 @@ ompi_report_comm_methods(int called_from_location)
                     if (is_nonconformist) {
                         char *str = malloc(1024);
 //                      int first = 1;
-                        sprintf(str, "  host %d:", i);
+                        snprintf(str, 1024, "  host %d:", i);
                         for (k=0; k<NUM_COMM_METHODS; ++k) {
                             if (method_count[k] > 0) {
 //                              if (!first) {
 //                                  strcat(str, " /");
 //                              }
-                                sprintf(&str[strlen(str)],
+                                snprintf(&str[strlen(str)],
+                                    1024 - strlen(str),
                                     " [%dx %s]",
                                     method_count[k],
                                     comm_method_to_string(k));

ompi/mca/sharedfp/lockedfile/sharedfp_lockedfile.c

@@ -117,7 +117,7 @@ struct mca_sharedfp_base_module_2_0_0_t * mca_sharedfp_lockedfile_component_file
 
     /* Set the filename. */
     /*data filename created by appending .locktest.$rank to the original filename*/
-    sprintf(filename,"%s%s%d",fh->f_filename,".locktest.",rank);
+    snprintf(filename, sizeof(filename), "%s%s%d",fh->f_filename,".locktest.",rank);
 
     lock.l_type   = F_WRLCK;
     lock.l_start  = 0;

opal/mca/btl/smcuda/btl_smcuda.c

@@ -486,7 +486,7 @@ static struct mca_btl_base_endpoint_t *create_sm_endpoint(int local_proc, struct
     OBJ_CONSTRUCT(&ep->pending_sends, opal_list_t);
     OBJ_CONSTRUCT(&ep->endpoint_lock, opal_mutex_t);
 #if OPAL_ENABLE_PROGRESS_THREADS == 1
-    sprintf(path, "%s" OPAL_PATH_SEP "sm_fifo.%lu", opal_process_info.job_session_dir,
+    snprintf(path, sizeof(path), "%s" OPAL_PATH_SEP "sm_fifo.%lu", opal_process_info.job_session_dir,
             (unsigned long) proc->proc_name);
     ep->fifo_fd = open(path, O_WRONLY);
     if (ep->fifo_fd < 0) {

opal/mca/btl/smcuda/btl_smcuda_component.c

@@ -859,8 +859,9 @@ mca_btl_smcuda_component_init(int *num_btls, bool enable_progress_threads, bool
 
 #if OPAL_ENABLE_PROGRESS_THREADS == 1
     /* create a named pipe to receive events  */
-    sprintf(mca_btl_smcuda_component.sm_fifo_path, "%s" OPAL_PATH_SEP "sm_fifo.%lu",
-            opal_process_info.job_session_dir, (unsigned long) OPAL_PROC_MY_NAME->vpid);
+    snprintf(mca_btl_smcuda_component.sm_fifo_path, sizeof(mca_btl_smcuda_component.sm_fifo_path),
+             "%s" OPAL_PATH_SEP "sm_fifo.%lu",
+             opal_process_info.job_session_dir, (unsigned long) OPAL_PROC_MY_NAME->vpid);
     if (mkfifo(mca_btl_smcuda_component.sm_fifo_path, 0660) < 0) {
         opal_output(0, "mca_btl_smcuda_component_init: mkfifo failed with errno=%d\n", errno);
         return NULL;

opal/mca/btl/tcp/btl_tcp_component.c

@@ -562,12 +562,12 @@ static int mca_btl_tcp_create(const int if_kindex, const char *if_name)
         btl->tcp_ifmask = selected_interface->if_mask;
 
         /* allow user to specify interface bandwidth */
-        sprintf(param, "bandwidth_%s", if_name);
+        snprintf(param, sizeof(param), "bandwidth_%s", if_name);
         mca_btl_tcp_param_register_uint(param, NULL, btl->super.btl_bandwidth, OPAL_INFO_LVL_5,
                                         &btl->super.btl_bandwidth);
 
         /* allow user to override/specify latency ranking */
-        sprintf(param, "latency_%s", if_name);
+        snprintf(param, sizeof(param), "latency_%s", if_name);
         mca_btl_tcp_param_register_uint(param, NULL, btl->super.btl_latency, OPAL_INFO_LVL_5,
                                         &btl->super.btl_latency);
         if (i > 0) {
@@ -576,12 +576,12 @@ static int mca_btl_tcp_create(const int if_kindex, const char *if_name)
         }
 
         /* allow user to specify interface bandwidth */
-        sprintf(param, "bandwidth_%s:%d", if_name, i);
+        snprintf(param, sizeof(param), "bandwidth_%s:%d", if_name, i);
         mca_btl_tcp_param_register_uint(param, NULL, btl->super.btl_bandwidth, OPAL_INFO_LVL_5,
                                         &btl->super.btl_bandwidth);
 
         /* allow user to override/specify latency ranking */
-        sprintf(param, "latency_%s:%d", if_name, i);
+        snprintf(param, sizeof(param), "latency_%s:%d", if_name, i);
         mca_btl_tcp_param_register_uint(param, NULL, btl->super.btl_latency, OPAL_INFO_LVL_5,
                                         &btl->super.btl_latency);
 

opal/util/timings.h

@@ -60,7 +60,8 @@ void opal_timing_disable_native_timers(void);
             if (n > OPAL_TIMING_STR_LEN) {                                        \
                 (_nm)->error = 1;                                                 \
             }                                                                     \
-            n = sprintf((_nm)->cntr_env, "OMPI_TIMING_%s_CNT", (_nm)->id);        \
+            n = snprintf((_nm)->cntr_env, OPAL_TIMING_STR_LEN,                    \
+                         "OMPI_TIMING_%s_CNT", (_nm)->id);                        \
             if (n > OPAL_TIMING_STR_LEN) {                                        \
                 (_nm)->error = 1;                                                 \
             }                                                                     \
@@ -135,7 +136,7 @@ void opal_timing_disable_native_timers(void);
                 }                                                                                  \
                 setenv(buf1, buf2, 1);                                                             \
                 h->cntr++;                                                                         \
-                sprintf(buf1, "%d", h->cntr);                                                      \
+                snprintf(buf1, OPAL_TIMING_STR_LEN, "%d", h->cntr);                                \
                 setenv(h->cntr_env, buf1, 1);                                                      \
                 /* We don't include env operations into the consideration.                         \
                  * Hopefully this will help to make measurements more accurate.                    \
@@ -187,19 +188,19 @@ void opal_timing_disable_native_timers(void);
             }                                                                                     \
         } while (0)
 
-#    define OPAL_TIMING_ENV_GETDESC_PREFIX(prefix, filename, func, i, desc, _t) \
-        do {                                                                    \
-            char vname[OPAL_TIMING_STR_LEN];                                    \
-            (_t) = 0.0;                                                         \
-            sprintf(vname, "OMPI_TIMING_%s_%s_FILE_%d", prefix, func, i);       \
-            *filename = getenv(vname);                                          \
-            sprintf(vname, "OMPI_TIMING_%s_%s_DESC_%d", prefix, func, i);       \
-            *desc = getenv(vname);                                              \
-            sprintf(vname, "OMPI_TIMING_%s_%s_VAL_%d", prefix, func, i);        \
-            char *ptr = getenv(vname);                                          \
-            if (NULL != ptr) {                                                  \
-                sscanf(ptr, "%lf", &(_t));                                      \
-            }                                                                   \
+#    define OPAL_TIMING_ENV_GETDESC_PREFIX(prefix, filename, func, i, desc, _t)                   \
+        do {                                                                                      \
+            char vname[OPAL_TIMING_STR_LEN];                                                      \
+            (_t) = 0.0;                                                                           \
+            snprintf(vname, OPAL_TIMING_STR_LEN, "OMPI_TIMING_%s_%s_FILE_%d", prefix, func, i);   \
+            *filename = getenv(vname);                                                            \
+            snprintf(vname, OPAL_TIMING_STR_LEN, "OMPI_TIMING_%s_%s_DESC_%d", prefix, func, i);   \
+            *desc = getenv(vname);                                                                \
+            snprintf(vname, OPAL_TIMING_STR_LEN, "OMPI_TIMING_%s_%s_VAL_%d", prefix, func, i);    \
+            char *ptr = getenv(vname);                                                            \
+            if (NULL != ptr) {                                                                    \
+                sscanf(ptr, "%lf", &(_t));                                                        \
+            }                                                                                     \
         } while (0)
 
 #    define OPAL_TIMING_ENV_GETDESC(file, func, index, desc) \

test/datatype/position.c

@@ -201,9 +201,9 @@ static char *bytes_dump(void *src, size_t cnt)
     static char text[1024];
     int index, i;
 
-    index = sprintf(text, "0x");
+    index = snprintf(text, sizeof(text), "0x");
     for (i = 0; i < (int) cnt; i++)
-        index += sprintf(text + index, "%x", (int) (((char *) src)[i]));
+        index += snprintf(text + index, sizeof(text) - index, "%x", (int) (((char *) src)[i]));
     *(text + index) = '\0';
     return text;
 }

test/simple/crisscross.c

@@ -92,7 +92,7 @@ int main(int argc, char *argv[])
     mpierr = MPI_Get_processor_name(process_name, &count);
     if (mpierr != MPI_SUCCESS) {
         fprintf(stderr, "MPI Error %d (MPI_Get_processor_name) [%d]\n", mpierr, rank);
-        sprintf(process_name, "%s", rr_empty);
+        snprintf(process_name, sizeof(process_name), "%s", rr_empty);
     } else {
         if (count < MAX_RR_NAME)
             strncat(&process_name[count], rr_blank, MAX_RR_NAME - count);

test/simple/no-disconnect.c

@@ -162,7 +162,7 @@ int main(int argc, char **argv)
         printf("level = %d\n", level);
 
         /* prepare send buffer */
-        sprintf(bufs, "level %d (pid:%d)", level, getpid());
+        snprintf(bufs, sizeof(bufs), "level %d (pid:%d)", level, getpid());
 
         /* spawn */
         if (level < max_depth) {