romio,java: cleanup deprecated hindexed call #1532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karol Mroz <[email protected]>
Signed-off-by: Karol Mroz <[email protected]>
|
@nrgraham23 could you check this? |
|
Java change looks good 👍 |
|
@hppritcha - Thank you for taking a look. |
|
@hjelmn You were the last one to do the ROMIO update (right?). We don't care about this kind of update to the ROMIO code base, right? The changes look small / trivial, remove some compiler warnings, and won't affect a new ROMIO update. Is that correct? If so, we might as well take this stuff. |
|
Yeah, and if they haven't fixed this upstream MPICH should probably make this change as well. |
|
Good point. @kmroz Might want to check the latest ROMIO and see if they've fixed this upstream. If they haven't might want to give them a heads up. |
|
@jsquyres - Thanks. I will look into upstream ROMIO and see if they have something similar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #1523.
I've left headers, makefiles and sources related to MPI_Type_hindexed() in place. Since I saw various other APIs marked as deprecated, I have no idea what you guys typically do in such cases?