datatype: Fix incorrect predefined datatype names and other datatype bugs #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Name of predefined datatype for C `unsigned int` gotten by `MPI_TYPE_GET_NAME` should be `MPI_UNSIGNED`, not `MPI_UNSIGNED_INT`.
Names of predefined datatypes gotten by `MPI_TYPE_GET_NAME` are: after this commit (correct) | before this commit (incorrect) ----------------------------------------------------------- MPI_C_BOOL MPI_BOOL MPI_CXX_BOOL MPI_BOOL MPI_CXX_FLOAT_COMPLEX MPI_C_FLOAT_COMPLEX MPI_CXX_DOUBLE_COMPLEX MPI_C_DOUBLE_COMPLEX MPI_CXX_LONG_DOUBLE_COMPLEX MPI_C_LONG_DOUBLE_COMPLEX
Name of the predefined datatype for Fortran two `double precision` gotten by `MPI_TYPE_GET_NAME` should be `MPI_2DOUBLE_PRECISION`, not `MPI_2DBLPREC`. This bug was caused by setting the name to `opal_datatype_t::name` instead of `ompi_datatype_t::name`.
`MPI_UNSIGNED_CHAR` is an integer type.
Just a typo fix. Without this fix, `MPI::MAX_LOC` and `MPI::MIN_LOC` cannot be used with `MPI::LONG_DOUBLE_INT` in C++ programs. I know the C++ binding is obsolete, but fixing this is harmless.
|
Rationale. A program to confirm names of predefined datatypes is on my gist. This program outputs names of predefined datatypes that doesn't have correct names defined in MPI standard. This program outputs |
|
I added the test from the gist into the ompi-tests/ibm/datatype test suite. |
|
👍 |
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
…bugs (open-mpi#1537) * datatype: Fix a incorrect datatype name of `MPI_UNSIGNED` Name of predefined datatype for C `unsigned int` gotten by `MPI_TYPE_GET_NAME` should be `MPI_UNSIGNED`, not `MPI_UNSIGNED_INT`. * datatype: Fix incorrect datatype names of `MPI_C_BOOL` and `MPI_CXX_*` Names of predefined datatypes gotten by `MPI_TYPE_GET_NAME` are: after this commit (correct) | before this commit (incorrect) ----------------------------------------------------------- MPI_C_BOOL MPI_BOOL MPI_CXX_BOOL MPI_BOOL MPI_CXX_FLOAT_COMPLEX MPI_C_FLOAT_COMPLEX MPI_CXX_DOUBLE_COMPLEX MPI_C_DOUBLE_COMPLEX MPI_CXX_LONG_DOUBLE_COMPLEX MPI_C_LONG_DOUBLE_COMPLEX * datatype: Fix a incorrect datatype name of `MPI_2DOUBLE_PRECISION` Name of the predefined datatype for Fortran two `double precision` gotten by `MPI_TYPE_GET_NAME` should be `MPI_2DOUBLE_PRECISION`, not `MPI_2DBLPREC`. This bug was caused by setting the name to `opal_datatype_t::name` instead of `ompi_datatype_t::name`. * datatype: Fix `MPI_UNSIGNED_CHAR` internal flag `MPI_UNSIGNED_CHAR` is an integer type. * ompi/cxx: Fix C++ `MPI::LONG_DOUBLE_INT` definition Just a typo fix. Without this fix, `MPI::MAX_LOC` and `MPI::MIN_LOC` cannot be used with `MPI::LONG_DOUBLE_INT` in C++ programs. I know the C++ binding is obsolete, but fixing this is harmless. * Add FUJITSU copyright (cherry picked from commit open-mpi/ompi@4944ba7)
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Sep 19, 2016
…bugs (open-mpi#1537) * datatype: Fix a incorrect datatype name of `MPI_UNSIGNED` Name of predefined datatype for C `unsigned int` gotten by `MPI_TYPE_GET_NAME` should be `MPI_UNSIGNED`, not `MPI_UNSIGNED_INT`. * datatype: Fix incorrect datatype names of `MPI_C_BOOL` and `MPI_CXX_*` Names of predefined datatypes gotten by `MPI_TYPE_GET_NAME` are: after this commit (correct) | before this commit (incorrect) ----------------------------------------------------------- MPI_C_BOOL MPI_BOOL MPI_CXX_BOOL MPI_BOOL MPI_CXX_FLOAT_COMPLEX MPI_C_FLOAT_COMPLEX MPI_CXX_DOUBLE_COMPLEX MPI_C_DOUBLE_COMPLEX MPI_CXX_LONG_DOUBLE_COMPLEX MPI_C_LONG_DOUBLE_COMPLEX * datatype: Fix a incorrect datatype name of `MPI_2DOUBLE_PRECISION` Name of the predefined datatype for Fortran two `double precision` gotten by `MPI_TYPE_GET_NAME` should be `MPI_2DOUBLE_PRECISION`, not `MPI_2DBLPREC`. This bug was caused by setting the name to `opal_datatype_t::name` instead of `ompi_datatype_t::name`. * datatype: Fix `MPI_UNSIGNED_CHAR` internal flag `MPI_UNSIGNED_CHAR` is an integer type. * ompi/cxx: Fix C++ `MPI::LONG_DOUBLE_INT` definition Just a typo fix. Without this fix, `MPI::MAX_LOC` and `MPI::MIN_LOC` cannot be used with `MPI::LONG_DOUBLE_INT` in C++ programs. I know the C++ binding is obsolete, but fixing this is harmless. * Add FUJITSU copyright (cherry picked from commit open-mpi/ompi@4944ba7)
bosilca
pushed a commit
to bosilca/ompi
that referenced
this pull request
Oct 3, 2016
…bugs (open-mpi#1537) * datatype: Fix a incorrect datatype name of `MPI_UNSIGNED` Name of predefined datatype for C `unsigned int` gotten by `MPI_TYPE_GET_NAME` should be `MPI_UNSIGNED`, not `MPI_UNSIGNED_INT`. * datatype: Fix incorrect datatype names of `MPI_C_BOOL` and `MPI_CXX_*` Names of predefined datatypes gotten by `MPI_TYPE_GET_NAME` are: after this commit (correct) | before this commit (incorrect) ----------------------------------------------------------- MPI_C_BOOL MPI_BOOL MPI_CXX_BOOL MPI_BOOL MPI_CXX_FLOAT_COMPLEX MPI_C_FLOAT_COMPLEX MPI_CXX_DOUBLE_COMPLEX MPI_C_DOUBLE_COMPLEX MPI_CXX_LONG_DOUBLE_COMPLEX MPI_C_LONG_DOUBLE_COMPLEX * datatype: Fix a incorrect datatype name of `MPI_2DOUBLE_PRECISION` Name of the predefined datatype for Fortran two `double precision` gotten by `MPI_TYPE_GET_NAME` should be `MPI_2DOUBLE_PRECISION`, not `MPI_2DBLPREC`. This bug was caused by setting the name to `opal_datatype_t::name` instead of `ompi_datatype_t::name`. * datatype: Fix `MPI_UNSIGNED_CHAR` internal flag `MPI_UNSIGNED_CHAR` is an integer type. * ompi/cxx: Fix C++ `MPI::LONG_DOUBLE_INT` definition Just a typo fix. Without this fix, `MPI::MAX_LOC` and `MPI::MIN_LOC` cannot be used with `MPI::LONG_DOUBLE_INT` in C++ programs. I know the C++ binding is obsolete, but fixing this is harmless. * Add FUJITSU copyright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit messages for detail.
@bosilca Please review