pmix/cray: set fence_nb to NULL #1600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than have a stub function for the pmix fence_nb operation, just set to NULL. Causes fewer problems. Fixes open-mpi#1597 Fixes open-mpi#1527 Signed-off-by: hppritcha <[email protected]>
|
ah, indeed - that would solve this problem! Thanks Howard - sorry I didn't spot that when I made the change. Any idea why it didn't show up in Jenkins? I'm changing the milestone to 2.0 as this doesn't exist in the 1.10 series. |
|
jenkins doesn't actually run anything, just makes sure it builds for cray. I'm going to change that now that NERSC switched to slurm - no need for job reservations for small jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than have a stub function for the pmix fence_nb
operation, just set to NULL. Causes fewer problems.
Fixes #1597
Fixes #1527
@rhc54
Signed-off-by: hppritcha [email protected]