hwloc/external: set WRAPPER_EXTRA_* vars in proper location #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WRAPPER_EXTRA flags are checked *before* the POST_CONFIG macro is invoked. So set them in the main CONFIG macro. Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/hwloc-wrapper-extra-flags-fix
branch
from
2ad4af7 to
eccf0ff
Compare
jsquyres
changed the title
|
I'll take care of the PMIx configure change. I know @jjhursey is looking at how we support multiple PMIx release versions, but I'll clean this up for the interim. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WRAPPER_EXTRA flags are checked before the POST_CONFIG macro is
invoked. So set them in the main CONFIG macro.
Signed-off-by: Jeff Squyres [email protected]
Refs #1655 -- but is not a complete fix. Someone needs to update
opal/mca/pmix/external/configure.m4per the discussion in #1655 (comment).