ompi/op: Provide a default value for type/flags #1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* User defined ops leave the op_type unset which can confuse logic in a collective component that is trying to convert the op to the approprate local function.
|
I made this a PR instead of committing directly. It seems like an oversight to initialize these variables, but I wanted to give folks a chance to review. |
|
Ignore Travis CI error. __atomic_compare_exchange_16 is not actually atomic on 10.9. Working on a fix. |
|
In general please don't commit directly in to master except for trivial/documentation changes. |
|
Fixed the Travis CI issue. :bot:retest: |
|
@hjelmn The travis failures still look like an OSX asm issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a collective component that is trying to convert the op to the
approprate local function.