pml/ob1: reset req_bytes_packed on start #1935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could fix #1875. Will update the commit message if it does. |
|
:bot:mellanox:retest |
On start we were not correctly resetting all request fields. This was leading to a double-completion on persistent receives. This commit updates the base start code to reset the receive req_bytes_packed and the send request convertor. Signed-off-by: Nathan Hjelm <[email protected]>
|
:bot:mellanox:retest |
|
looks like there may be some kind of install issue of HCOLL at MLNX. |
|
@hppritcha Sorry for the noise. We hope to have it fixed soon. We are aware. |
|
Thank you! |
|
bot:mellanox:retest |
1 similar comment
|
bot:mellanox:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On start we were not correctly resetting all request fields. This was
leading to a double-completion on persistent receives. This commit
updates the base start code to reset both the send and receive request
req_bytes_packed fields in the START macros. The only pml that appears
to be affected is ob1.
Signed-off-by: Nathan Hjelm [email protected]