code cleanup: clang is now a happier panda #1940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orte/runtime/orte_data_server.c
Outdated
| opal_pmix_data_range_t range; | ||
| orte_data_req_t *req, *rqnext; | ||
| orte_jobid_t jobid; | ||
| orte_jobid_t jobid = 0; |
There was a problem hiding this comment.
I guess it must think there is some path that allows jobid to be used without having been unpacked? I can't readily see it - would be nice to know what it is and fix it.
Regardless, you'd be better off initializing it to ORTE_JOBID_INVALID as job=0 is the daemon job and a legitimate value.
Clang 5.1 on my mac was a sad panda compiling a couple of files, complaining about uninitialized stack variables. This commit makes clang a happier panda (or at least not so sad). Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
topic/make_clang_happy_panda
branch
from
800d253 to
ff669e7
Compare
|
looks like mlnx has an HCOLL install issue. |
|
part of this commit needs to be patched back in to v2.x so assigning 2.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 5.1 on my mac was a sad panda compiling a couple
of files, complaining about uninitialized stack variables.
This commit makes clang a happier panda (or at least not so sad).
@rhc54
Signed-off-by: Howard Pritchard [email protected]