Skip to content

add a --disable-io-ompio option #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2016
Merged

add a --disable-io-ompio option #2020

merged 1 commit into from
Sep 23, 2016
+66 −22

Conversation

@ggouaillardet
Copy link
Contributor

No description provided.

@ggouaillardet ggouaillardet added this to the v2.0.2 milestone Aug 26, 2016
@ggouaillardet
Copy link
Contributor Author

this can be merged after #2018

@lanl-ompi
Copy link
Contributor

Test FAILed.

2 similar comments
@lanl-ompi
Copy link
Contributor

Test FAILed.

@lanl-ompi
Copy link
Contributor

Test FAILed.

@ibm-ompi
Copy link

Build Failed with XL compiler! Please review the log, and get in touch if you have questions.

Gist: https://gist.github.com/72bdc8f390f2f98718ecc5153166804b

@ggouaillardet
Copy link
Contributor Author

there is obviously something wrong when --disable-io-ompio is not used
i will investigate this later

@ibm-ompi
Copy link

Build Failed with GNU compiler! Please review the log, and get in touch if you have questions.

Gist: https://gist.github.com/63aba401e927726e6694948ae56f9757

@ggouaillardet ggouaillardet force-pushed the topic/disable_io_ompio branch from a52da09 to 4241872 Compare August 29, 2016 01:21
@ggouaillardet ggouaillardet mentioned this pull request Aug 29, 2016
Merged
@ggouaillardet
Copy link
Contributor Author

this PR has been rebased on top of the latest #2018 and updated

@jsquyres jsquyres modified the milestones: v2.1.0, v2.0.2 Sep 22, 2016
@jsquyres
Copy link
Member

@ggouaillardet:

  • Is this still a WIP / DNM? (that label is still on here)
  • Do you need to rebase on top of master head to effectively remove the first commit on this PR?
  • You might want to put "Closes add a --disable-io-ompio configure flag #1934" in here somewhere since this PR will fix that issue.

Also, since this is an enhancement, it needs to go to v2.1.0. I updated the milestone.

@ggouaillardet
Copy link
Contributor Author

Will update tomorrow

Since the first commit has been merged, merging the request should be fine.
That could be a github bug, since the first commit should have been removed from the PR

@ggouaillardet
configury: add the --disable-io-ompio option
6b57b77 
--disable-io-ompio is a shortcut that disable the following
frameworks and components
- fbtl
- fcoll
- sharedfp
- common/ompio
- io/ompio

Fixes open-mpi#1934
@ggouaillardet
Copy link
Contributor Author

@jsquyres we should be good now
i confirm github does not remove commits that have been merged from a PR

@jsquyres jsquyres merged commit 34c036a into open-mpi:master Sep 23, 2016
@jjhursey
Copy link
Member

Thanks!

clementFoyer pushed a commit to bosilca/ompi that referenced this pull request Nov 4, 2016
@jsquyres
Merge pull request open-mpi#2020 from ggouaillardet/topic/disable_io_…
1f342a8 
…ompio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jsquyres jsquyres

@edgargabriel edgargabriel

Labels

enhancement

Projects

None yet

Milestone

v2.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ggouaillardet @lanl-ompi @ibm-ompi @jsquyres @jjhursey @edgargabriel