Several fixes related to session directories: #2042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
artpol84
commented
Sep 1, 2016
artpol84
commented
- enable OMPI to retrieve paths from RM through PMIx
- cleanups related to tempdirs.
|
@rhc54 This is a draft of what we were talking about on PMIx call. I'm still verifying the code but the conception should be clear. Could you take a look and see if you are OK with this. I will also add the PMIx keys to indicate that RM has created directories and that it will clean them up for OMPI as we discussed. I will implement this as a separate commit. |
artpol84
force-pushed
the
pmix_sdirs
branch
2 times, most recently
from
76f1718 to
ec73484
Compare
|
The keys are added but I need to test them with SLURM. |
* enable OMPI to retrieve paths from RM through PMIx * cleanups related to tempdirs.
session directories provided at through OPAL_PMIX_TMPDIR, OPAL_PMIX_NSDIR, OPAL_PMIX_PROCDIR
|
@rhc54 This works well for me now! Please have a look. |
|
As per today's PMIx telecon, this looks fine. Just replace your Thanks! 👍 |
|
#2072 Has a dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.