Error handling improvements

[nrgraham23]

This commit improves and corrects error handling. In
cases where existing objects are altered after a call
to ompi_java_exceptionCheck, the results of the exception
check method are checked. In the case of an exception,
memory is cleaned up and the code returns to Java without
altering existing objects.

Signed-off-by: Nathaniel Graham [email protected]

Fixes #1698

@hppritcha please review this when you get a chance.

[lanl-ompi]

Test FAILed.

[hppritcha]

looks good but please update the LANL copyright lines on the changed files.

[siegmargross]

Thank you very much for the fix. With the following addition to your version of the exception program, I get what I want. I found the solution for the root cause on stackoverflow.

catch (IndexOutOfBoundsException e) {
  System.err.println("Handle index out of bounds here");
  /* Try to find the root cause for the exception                   */
  Throwable cause = null; 
  Throwable result = e;
  while (null != (cause = result.getCause()) && (result != cause))  {
    result = cause;
  }
  System.err.printf ("  Process %2d: Error message: %s\n",  mytid, result);
}