Skip to content

Conversation

@xinzhao3
Copy link
Contributor

No description provided.

@jladd-mlnx jladd-mlnx added this to the v2.x milestone Dec 15, 2016
@jladd-mlnx
Copy link
Member

@xinzhao3 For future reference, please add the signed-off-by token to your commits with git commit -s option. Please do a git commit --amend -s to add the singed-off-by token, you'll need to git push YOUR_REMOTE --force to force push to get that commit up here to Github (because you're changing git history).

Note that just about the only time it is acceptable to force push is for pull requests that have not yet been merged.

@xinzhao3
Copy link
Contributor Author

@jladd-mlnx
Will add signed-off for future commits.
For this commit, do you mean I force push it with signed-off (after all tests are done)?

@jladd-mlnx
Copy link
Member

@xinzhao3 Force push it now. No need to wait for tests to pass.

@xinzhao3 xinzhao3 force-pushed the topic/ucx-mt-support branch from 26b15c7 to 0ecf3c9 Compare December 15, 2016 21:59
@jladd-mlnx jladd-mlnx merged commit d8c1a3d into open-mpi:master Dec 16, 2016
@xinzhao3 xinzhao3 deleted the topic/ucx-mt-support branch March 13, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants