Mpirun man update #3019
Merged
Mpirun man update #3019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
requested changes
Feb 22, 2017
There was a problem hiding this comment.
@nrgraham23 I like how you split it up into the cherry-pick and another to remove stuff that's not here on the branch. Nice!
Can you add the cherry-pick notice into the first commit message so that we can tell what commit it came from on master? Usually, you can do git cherry-pick -x HASH, where the -x has git automatically insert a line like this at the bottom of the commit:
(cherry picked from commit 048f757d9f7dd5fe53217bdd8604a37db3d123f2)
Can you manually add a line like that in your first commit? (with the proper commit hash, of course)
hppritcha
approved these changes
Feb 23, 2017
|
Approved modulo @jsquyres requested commit cherry pick comment |
added 2 commits
February 23, 2017 10:33
This update should fix the mpirun man page so all mpirun command line options are included, and mpirun commands that have been removed are no longer in the man page. I also fixed some of the file formatting, and bolding of command parameters. Signed-off-by: Nathaniel Graham <[email protected]> (cherry picked from commit f9c05bd)
This commit removes the man entries for commands which are not included in v2.x. Signed-off-by: Nathaniel Graham <[email protected]>
nrgraham23
force-pushed
the
mpirun_man_update
branch
from
f306f91 to
db02d85
Compare
|
Updated the cherry-picked commit. Ill remember that -x option for next time. |
jsquyres
approved these changes
Feb 23, 2017
|
Sweet; thanks @nrgraham23 |
|
This is a man page update; not waiting for CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates for the mpirun man page. The first commit is a cherry-pick from master. The second commit removes options that are not available in v2.x
@jsquyres @hppritcha