ompi/comm: Improve MPI_Comm_create algorithm (v3.x) #3377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artpol84
force-pushed
the
comm_create/v3.x
branch
from
b85f97f to
88834e9
Compare
Efficiency verification |
Force only procs that are participating in the ne Comm to decide what
CID is appropriate. This will have 2 advantages:
* Speedup Comm creation for small communicators: non-participating procs
will not interfere
* Reduce CID fragmentation: non-overlaping groups will be allowed to use
same CID.
Signed-off-by: Artem Polyakov <[email protected]>
(cherry picked from commit f1f7f20)
artpol84
force-pushed
the
comm_create/v3.x
branch
from
88834e9 to
9a9730e
Compare
|
Test Passed |
MTT verification |
|
Do not merge until #3375 is merged. |
|
Is this a bug or an enhancement? It really feels like an enhancement that we shouldn't backport into all the releases... |
|
Closing this PR, as we aren't going to pull this enhancement into 3.0; it will be in the fall release, since it's already in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Polyakov [email protected]
(cherry picked from commit 50a6d10)