ompi/comm: Improve MPI_Comm_create algorithm (v2.0.x) #3388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Efficiency verification |
Force only procs that are participating in the ne Comm to decide what
CID is appropriate. This will have 2 advantages:
* Speedup Comm creation for small communicators: non-participating procs
will not interfere
* Reduce CID fragmentation: non-overlaping groups will be allowed to use
same CID.
Signed-off-by: Artem Polyakov <[email protected]>
(cherry picked from commit f1f7f20)
artpol84
force-pushed
the
comm_create/v2.0.x
branch
from
807cc6e to
548092d
Compare
|
Test Passed |
Contributor
Author
MTT verification |
| for (unsigned int i = context->start ; i < mca_pml.pml_max_contextid ; ++i) { | ||
| flag = opal_pointer_array_test_and_set_item (&ompi_mpi_communicators, i, | ||
| context->comm); | ||
| if (true == flag) { |
Contributor
There was a problem hiding this comment.
minor quibble, if (true == flag) could be changed to if (flag)
| bool flag; | ||
| flag = opal_pointer_array_test_and_set_item (&ompi_mpi_communicators, i, | ||
| context->comm); | ||
| if (true == flag) { |
Contributor
There was a problem hiding this comment.
minor quibble, if (true == flag) could be changed to if (flag)
Member
|
Do not merge until #3375 is merged. |
| ompi_request_t *subreq; | ||
| bool flag; | ||
| int ret; | ||
| int participate = (context->newcomm->c_local_group->grp_my_rank != MPI_UNDEFINED); |
Contributor
There was a problem hiding this comment.
minor quibble, participate could be a boolean
| ompi_comm_cid_context_t *context = (ompi_comm_cid_context_t *) request->context; | ||
| ompi_request_t *subreq; | ||
| int ret; | ||
| int participate = (context->newcomm->c_local_group->grp_my_rank != MPI_UNDEFINED); |
Contributor
There was a problem hiding this comment.
minor quibble, participate could be a boolean
|
|
||
| static int ompi_comm_nextcid_check_flag (ompi_comm_request_t *request) | ||
| { | ||
| ompi_comm_cid_context_t *context = (ompi_comm_cid_context_t *) request->context; |
Contributor
There was a problem hiding this comment.
minor quibble, participate could be a boolean
Member
|
Per discussion on the 2017-04-26 webex and per further discussion by the RMs on 2017-04-26, this appears to be an enhancement that isn't classified as a bug fix (e.g., no customer problems were cited). As such, we're dropping it from v2.0.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Polyakov [email protected]
(cherry picked from commit f1f7f20)