v2.1.1: update the VERSION file #3420
Conversation
There was a problem hiding this comment.
@hppritcha Given the comments I made, I'm not sure we're looking at the same commit range on the v2.x branch. Can you verify that I'm looking at the right range of commits?
VERSION
Outdated
| # format. | ||
|
|
||
| libmpi_so_version=30:0:10 | ||
| libmpi_so_version=31:0:11 |
There was a problem hiding this comment.
I agree with the libmpifh version change, but I do not see an mpi.h change that would cause this libmpi_so_version change. I'm looking on the v2.x branch starting with the 62cd194 commit. Are we looking at the same commit range?
There was a problem hiding this comment.
Ok, I guess I shouldn't be using --no-merge in my git log.
So I now see fda9157 that modified mpi.h. But it just added a #define -- it didn't add any interfaces. So I don't think we should be bumping to 31:0:11, but rather to 30:1:10.
| libopen_pal_so_version=30:1:10 | ||
| libmpi_java_so_version=30:0:10 | ||
| liboshmem_so_version=30:0:10 | ||
| liboshmem_so_version=30:1:10 |
There was a problem hiding this comment.
I didn't see any OSHMEM changes on v2.x after 62cd194. Did I miss them?
There was a problem hiding this comment.
Ok, I see the oshmem change now.
| libmca_opal_common_cuda_so_version=30:0:10 | ||
| libmca_opal_common_libfabric_so_version=30:0:10 | ||
| libmca_opal_common_sm_so_version=30:0:10 | ||
| libmca_opal_common_sm_so_version=30:1:10 |
There was a problem hiding this comment.
I also didn't see any opal/mca/common/sm changes on v2.x after 62cd194.
There was a problem hiding this comment.
And I see the common/sm change now.
|
I got the list of changed files by checking out v2.x in my repo and then doing git diff --name-only 1cd1edf..HEAD the sha is that for the v2.1.0 tag |
|
Sorry typed the sha wrong. Typing on my iphone |
|
What got command are you using? The pvar sessions thing got merged in as 3139. hmmm that was the thing I missed in the readme. |
|
Looks like I started 1 commit after you, and that didn't really affect any noticeable change. I just checked out the |
|
i dont think your command is the right one. |
|
Problem is that things like the mpi.h.in change was only merged in a few weeks ago. |
|
#3139 pulled that change in. I merged Omir's commit on 3/29. |
|
same kind of mistake with the sm common. The change was actually merged in by #3189 which got merged in by me on 3/28. |
|
Oh I noticed I had updated NEWS with #3139 info. Just forgot to delete the reminder line. So the README should be ready to go. |
|
Only thing left now is the version for libmpi. |
|
Your git command is defective for finding changes between releases, at least within a given branch. I'll update the release checklist. |
the upping of age and rev for libmpi.so/libmpif owes to additions to the mpi.h and mpif.h include files. [ci skip] Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
version_update_v2.1.1
branch
from
4fb1b44 to
3c5254d
Compare
There was a problem hiding this comment.
@hppritcha and I talked in IM and figured it all out. We agree that the values are good now.
2 participants
the upping of age and rev for libmpi.so/libmpif owes
to additions to the mpi.h and mpif.h include files.
[ci skip]
Signed-off-by: Howard Pritchard [email protected]