master: mtl-portals4: add timeout to rendezvous get fragments #3837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Kordenbrock <[email protected]>
Signed-off-by: Todd Kordenbrock <[email protected]>
If the a frag cannot be retried because the ni_fail_type is other than PTL_NI_DROPPED, then set the return type and jump to callback_error. This sets MPI_ERROR and completes the receive. Signed-off-by: Todd Kordenbrock <[email protected]>
Rearrange the receive frag timeout logic to avoid calling opal_timer_base_get_usec() in read_msg(). Instead set it at the first retry. Signed-off-by: Todd Kordenbrock <[email protected]>
|
@regrant is this an enhancement? Adding a new MCA parameter to releases that are now in bug fix only mode (2.0.x and 2.x) makes accepting this PR into those release problematic. |
|
@hppritcha I agree this should go into 3.X not the 2.X series. It's an enhancement to a previous bug fix to make it more efficient and therefore an enhancement. |
regrant
approved these changes
Jul 13, 2017
|
This looks like a PR for master. You should probably remove the target:3.0 tag and file a new PR for the merge to 3.0 once this is in master (anyone can approve the pull into master, so that's all you...). |
|
@bwbarrett thanks I missed the master tag, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a timeout to each fragment of a rendezvous get. If any fragment times out or fails, the entire receive fails.
Signed-off-by: Todd Kordenbrock [email protected]