v3.1: configury: revamp ucx detection #4397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Per #4383 (comment), I'm confused by the commit message in this PR. |
Member
|
bot:ompi:retest |
jsquyres
changed the title
Member
|
@ggouaillardet, the 3.1 version of this patch doesn't apply; can you update? |
ggouaillardet
force-pushed
the
topic/v3.1.x/configury_ucx
branch
from
57fad01 to
ebdd7b9
Compare
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/d7a7bd6751e9792579ccb2da74a7e6c8 |
|
The IBM CI (GNU Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/9c1252e93f04093c0ed6a9b7e8e90b40 |
|
The IBM CI (PGI Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/f7361c959106e92123efef861529224f |
- when --with-ucx=DIR is not set, try the default path and fallback to /opt/ucx - when --with-ucx-libdir is not set, try lib64 and then lib directories - do not handle --with-ucx-libdir (this is a user mistake, no need to over-complicate our logic) Signed-off-by: Gilles Gouaillardet <[email protected]> (back-ported from commit open-mpi/ompi@af03f55)
ggouaillardet
force-pushed
the
topic/v3.1.x/configury_ucx
branch
from
ebdd7b9 to
76de6ca
Compare
Member
|
can we either review or close this PR? It seems to be stuck in review required for many moons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs. #4345
Signed-off-by: Gilles Gouaillardet [email protected]
(cherry picked from commit af03f55)