MTL OFI updates #4494
MTL OFI updates #4494
Conversation
No code or logic changes. Signed-off-by: Jeff Squyres <[email protected]>
No code or logic changes. Signed-off-by: Jeff Squyres <[email protected]>
The value of ret is negative (e.g., -61), but it is displayed in the help message as `%zd`, which renders as unsigned (i.e., a giant positive value). So make sure to negate the negative value before rendering it (e.g., so we display "61", not "4294967235"). Signed-off-by: Jeff Squyres <[email protected]>
Before this commit, the presence of usNIC devices -- which will (currently) return no data when fi_getinfo() is queried for tagged matching providers -- would cause an error message to be displayed. Signed-off-by: Jeff Squyres <[email protected]>
gcc 5.2 complains:
```
mtl_ofi_component.c: In function ‘ompi_mtl_ofi_finalize’:
mtl_ofi_component.c:613:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
if (ret = fi_close((fid_t)ompi_mtl_ofi.fabric)) {
^
```
Signed-off-by: Jeff Squyres <[email protected]>
|
Note: v2.0.x has a similar issue (i.e., shows a warning if The problem with v2.x and beyond is that it uses |
|
All Tests Passed! |
|
checking to see if ompi jenkins chattiness has been disabled if tests pass. |
|
All Tests Passed! |
|
Thanks @aravindksg |
| &providers); /* Out: List of matching providers */ | ||
| if (0 != ret) { | ||
| if (FI_ENODATA == -ret) { | ||
| // It is not an error if no information is returned. |
There was a problem hiding this comment.
minor: c++ comment style
There was a problem hiding this comment.
We allow this in Open MPI (since compiling Open MPI requires a C99 compiler, which officially standardized //-style comments in C).
| opal_progress_unregister(ompi_mtl_ofi_progress_no_inline); | ||
|
|
||
| /* Close all the OFI objects */ | ||
| if (ret = fi_close((fid_t)ompi_mtl_ofi.ep)) { |
There was a problem hiding this comment.
why the extra parenthesis ?
There was a problem hiding this comment.
See the commit message on a8686a6.
5 participants
The most important of these is to not show an error if
fi_getinfo()returns no data.Need to get these fixes in to release branches before they go out, or usNIC customers will be asking my why they are getting these warnings. 😦 This affects:
These commits should be added to #4458 and #4459 before those PRs are merged.