hwloc: bring back the configure error when external hwloc is >= 2.0 #4934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll remove this when/if hwloc 2.0 support ever comes back to this branch. Right now we have 1.11.7 internal (since bd9a568) and the OMPI side of the code only supports a non-final version of hwloc 2.0 API. This is partial revert of 60aa9cf (only the configure part of it) which added support for that non-final version of the hwloc 2.0 API. Signed-off-by: Brice Goglin <[email protected]>
jsquyres
approved these changes
Mar 21, 2018
Member
|
#4936 was accidentally a dup of this one. So let's merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jsquyres Here's the patch to abort configure in 3.1 if hwloc external is 2.0.
@ggouaillardet added that code a while ago (it's still in 3.0.x, no need to backport there). Then he removed it from master/3.1.x when porting OMPI to the non-final hwloc 2.0 API (which isn't done yet). I am putting it back in 3.1.x but not in master.