v3.0.x: Update to PMIx 2.0.3 #4989
Conversation
Signed-off-by: Joshua Hursey <[email protected]>
|
whistle...wow, that's a big amount of change, dude! Are the RMs going to accept this? |
|
They are using PMIx 2.0.1rc1 right now. If they want cross version support in v3.0.1 then it should be considered. I'll leave it to the RMs. |
| PMIX_INFO_CREATE(info, ninfo); | ||
| cnt=ninfo; | ||
| if (PMIX_SUCCESS != (rc = pmix_bfrop.unpack(buf, info, &cnt, PMIX_INFO))) { | ||
| if (0 < cd->ninfo) { |
There was a problem hiding this comment.
@jjhursey I recvd a request that we always provide the PMIX_PARENT_ID and PMIX_SPAWNED attributes when a client proc (but not a tool) dynamically starts another job. See the code now in master - might be an idea to backport it here for consistency.
There was a problem hiding this comment.
NOTE: my "changes request" relates solely to the above comment. Otherwise, things look fine to me, so I'll change my review to "approved" as the above is optional and up to @jjhursey .
|
@hppritcha @jsquyres Just to clarify (since I commented about the size of this PR) - much of the changes consist of mods to copyrights and removal of some files. Of the remaining changes, they fall into three categories:
The first category is the smallest of the group, and so I'd recommend moving ahead with it (precise timing is up to you). |
|
After some discussion, since Open MPI 3.0.1 is all but released (all that's left is the web page update), we're going to release 3.0.1 without this patch and ship it with 3.0.2, targetted for 1 month out. |
4 participants
No description provided.