fortran: build MPI_Sizeof() interface in use-mpi-tkr bindings #5101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whenever possible. Add the missing OMPI_FORTRAN_BUILD_SIZEOF macro to Fortran and add a missing dependency. Thanks Themos Tsikas for reporting this issue. Refs open-mpi#5085 Signed-off-by: Gilles Gouaillardet <[email protected]> (back-ported from commit open-mpi/ompi@2abeada)
Member
|
@ThemosTsikas Can you confirm that this PR fixes the issue for you with the v3.0.x branch? |
jsquyres
approved these changes
Apr 25, 2018
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
NEWS comment: Fixed MPI_SIZEOF in the "mpi" Fortran module for the NAG compiler.
(applied to the v2.x, v3.0.x, and v3.1.x branches)
Set mpi.lo dependencies outside of AM conditionals. Per open-mpi#5085, make mpi.lo depend on whatever we decide the sizeof source files are (which may be empty, if this compiler does not support the Right Stuff for MPI_SIZEOF, or it may be mpi-tkr-sizeof.[h|f90]). Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit open-mpi/ompi@5bd02f6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whenever possible.
Add the missing OMPI_FORTRAN_BUILD_SIZEOF macro to Fortran
and add a missing dependency.
Thanks Themos Tsikas for reporting this issue.
Refs #5085
Signed-off-by: Gilles Gouaillardet [email protected]
(back-ported from commit 2abeada)