PML/UCX: reset converter stack on unordered messages #5175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Oblomov <[email protected]>
hoopoepg
force-pushed
the
topic/reset-stack-on-unordered
branch
from
34c82c7 to
7c5de01
Compare
Signed-off-by: Sergey Oblomov <[email protected]>
hoopoepg
force-pushed
the
topic/reset-stack-on-unordered
branch
from
04824c5 to
19607da
Compare
yosefe
approved these changes
May 21, 2018
Contributor
|
@bosilca can you pls take a look? |
bosilca
reviewed
May 21, 2018
Member
bosilca
left a comment
bosilca
left a comment
There was a problem hiding this comment.
I have a question about threading. As you keep the offset in the ucx_datatype how are you ensuring that if multiple threads unpack data in same time they do not collide on the use (and update) of the offset field?
ompi/mca/pml/ucx/pml_ucx_datatype.c
Outdated
| /* permanently switch to un-ordered mode */ | ||
| convertor->offset = 0; | ||
| } else { | ||
| opal_convertor_set_position(&convertor->opal_conv, &offset); |
Member
There was a problem hiding this comment.
If you are here the convertor is already set at the right position, so the call to opal_convertor_set_position is unnecessary.
Contributor
Author
|
UCX receives data in single thread only (even for cases out-of-order/multi-rail mode) |
Signed-off-by: Sergey Oblomov <[email protected]>
hoopoepg
force-pushed
the
topic/reset-stack-on-unordered
branch
from
bc3d9b3 to
5ec2691
Compare
bosilca
approved these changes
May 21, 2018
Contributor
|
@hoopoepg pls pick to v3.1.x |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for openucx/ucx#2568