MTL OFI: Fix race condition due to global progress entries array #5620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since progress entries array is globally allocated, it is susceptible to race conditions when using multi-threaded applications. Allocating it on the stack resolves any potential races as it is thread local by default. (cherry picked from commit ed23430) Signed-off-by: Aravind Gopalakrishnan <[email protected]> Conflicts: ompi/mca/mtl/ofi/mtl_ofi_component.c ompi/mca/mtl/ofi/mtl_ofi_types.h
hppritcha
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since progress entries array is globally allocated, it is susceptible
to race conditions when using multi-threaded applications. Allocating it
on the stack resolves any potential races as it is thread local by default.
(cherry picked from commit ed23430)
Signed-off-by: Aravind Gopalakrishnan [email protected]
Conflicts:
ompi/mca/mtl/ofi/mtl_ofi_component.c
ompi/mca/mtl/ofi/mtl_ofi_types.h
Conflicts were mainly due to some features in master and not in the release branch. So git was complaining about missing lines while cherry-picking.