v3.1.x: make common/verbs-usnic actually check if it can compile #5635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone specifies --with-verbs-usnic, actually do a configury check to ensure that it will compile (vs. assuming that it will compile if someone asks for it). Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 05e5f61)
This option isn't needed on modern distros; add a note to README about it. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 9a8b0d0)
hppritcha
approved these changes
Sep 4, 2018
jsquyres
deleted the
pr/v3.1.x/verbs-usnic-configury-moar-strictness
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only checked to see if the user specified
--with-verbs-usnic. Now do the Right Thing and actually verify that it can compile, too.