Skip to content

Fix misc issues evidenced whey building on msys2 arch #6002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix misc issues evidenced whey building on msys2 arch #6002

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc5acc4
mpool/base: add missing #include
ggouaillardet Oct 31, 2018
c8ec6ad
configury: rename a pushed variable in OPAL_CONFIG_SUBDIR
ggouaillardet Oct 30, 2018
4406c2c
configury: add missing dependencies
ggouaillardet Oct 30, 2018
aaae58f
use #ifdef with AC_CHECK_HEADERS() generated macros
ggouaillardet Oct 31, 2018
688aec3
misc stuff
ggouaillardet Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions ompi/mca/common/monitoring/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
# of Tennessee Research Foundation. All rights
# reserved.
# Copyright (c) 2016 Inria. All rights reserved.
# Copyright (c) 2017 Research Organization for Information Science
# and Technology (RIST). All rights reserved.
# Copyright (c) 2017-2018 Research Organization for Information Science
# and Technology (RIST). All rights reserved.
# Copyright (c) 2018 Cisco Systems, Inc. All rights reserved
# $COPYRIGHT$
#
Expand All @@ -13,11 +13,15 @@
# $HEADER$
#

include $(top_srcdir)/Makefile.ompi-rules
Copy link
Member

@jsquyres jsquyres Dec 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message on this commit no longer matches what the commit actually does.

I don't know / care if you want to split this into multiple commits:

  • Add the dependencies
  • Fix the comments
  • Use Makefile.ompi-rules


EXTRA_DIST = profile2mat.pl aggregate_profile.pl

sources = common_monitoring.c common_monitoring_coll.c
headers = common_monitoring.h common_monitoring_coll.h

# See the comments in opal/mca/common/sm/Makefile.am for the explanations

lib_LTLIBRARIES =
noinst_LTLIBRARIES =
component_install = libmca_common_monitoring.la
Expand Down Expand Up @@ -50,15 +54,7 @@ libmca_common_monitoring_la_LDFLAGS = \
libmca_common_monitoring_la_LIBADD = $(common_monitoring_LIBS)
libmca_common_monitoring_noinst_la_SOURCES = $(headers) $(sources)

# These two rules will sym link the "noinst" libtool library filename
# to the installable libtool library filename in the case where we are
# compiling this component statically (case 2), described above).
V=0
OMPI_V_LN_SCOMP = $(ompi__v_LN_SCOMP_$V)
ompi__v_LN_SCOMP_ = $(ompi__v_LN_SCOMP_$AM_DEFAULT_VERBOSITY)
ompi__v_LN_SCOMP_0 = @echo " LN_S " `basename $(component_install)`;

all-local:
all-local: $(component_noinst)
Copy link
Member

@jsquyres jsquyres Dec 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're now including Makefile.ompi-rules, I think you need to also change OMPI_V_LN_SCOMP to OMPI_V_LN_S everywhere.

$(OMPI_V_LN_SCOMP) if test -z "$(lib_LTLIBRARIES)"; then \
rm -f "$(component_install)"; \
$(LN_S) "$(component_noinst)" "$(component_install)"; \
Expand Down
23 changes: 5 additions & 18 deletions ompi/mca/common/ompio/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# Copyright (c) 2008-2018 University of Houston. All rights reserved.
# Copyright (c) 2016 IBM Corporation. All rights reserved.
# Copyright (c) 2017-2018 Research Organization for Information Science
# and Technology (RIST). All rights reserved.
# and Technology (RIST). All rights reserved.
#
# $COPYRIGHT$
#
Expand All @@ -21,6 +21,8 @@
# $HEADER$
#

include $(top_srcdir)/Makefile.ompi-rules

headers = \
common_ompio_aggregators.h \
common_ompio_print_queue.h \
Expand All @@ -37,14 +39,7 @@ sources = \
common_ompio_file_write.c


# To simplify components that link to this library, we will *always*
# have an output libtool library named libmca_<type>_<name>.la -- even
# for case 2) described above (i.e., so there's no conditional logic
# necessary in component Makefile.am's that link to this library).
# Hence, if we're creating a noinst version of this library (i.e.,
# case 2), we sym link it to the libmca_<type>_<name>.la name
# (libtool will do the Right Things under the covers). See the
# all-local and clean-local rules, below, for how this is effected.
# See the comments in opal/mca/common/sm/Makefile.am for the explanations

lib_LTLIBRARIES =
noinst_LTLIBRARIES =
Expand Down Expand Up @@ -79,15 +74,7 @@ headers += common_ompio_cuda.h
sources += common_ompio_cuda.c
endif

# These two rules will sym link the "noinst" libtool library filename
# to the installable libtool library filename in the case where we are
# compiling this component statically (case 2), described above).
V=0
OMPI_V_LN_SCOMP = $(ompi__v_LN_SCOMP_$V)
ompi__v_LN_SCOMP_ = $(ompi__v_LN_SCOMP_$AM_DEFAULT_VERBOSITY)
ompi__v_LN_SCOMP_0 = @echo " LN_S " `basename $(comp_inst)`;

all-local:
all-local: $(comp_noinst)
$(OMPI_V_LN_SCOMP) if test -z "$(lib_LTLIBRARIES)"; then \
rm -f "$(comp_inst)"; \
$(LN_S) "$(comp_noinst)" "$(comp_inst)"; \
Expand Down
12 changes: 5 additions & 7 deletions opal/mca/common/sm/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
# Copyright (c) 2010-2015 Cisco Systems, Inc. All rights reserved.
# Copyright (c) 2010-2015 Los Alamos National Security, LLC.
# All rights reserved.
# Copyright (c) 2018 Research Organization for Information Science
# and Technology (RIST). All rights reserved.
# $COPYRIGHT$
#
# Additional copyrights may follow
Expand Down Expand Up @@ -41,6 +43,8 @@
# Note that building this common component statically and linking
# against other dynamic components is *not* supported!

include $(top_srcdir)/Makefile.ompi-rules

# Header files

headers = \
Expand Down Expand Up @@ -101,13 +105,7 @@ endif
# to the installable libtool library filename in the case where we are
# compiling this component statically (case 2), described above).

# See Makefile.ompi-rules for an explanation of the "V" macros, below
V=0
OMPI_V_LN_SCOMP = $(ompi__v_LN_SCOMP_$V)
ompi__v_LN_SCOMP_ = $(ompi__v_LN_SCOMP_$AM_DEFAULT_VERBOSITY)
ompi__v_LN_SCOMP_0 = @echo " LN_S " `basename $(comp_inst)`;

all-local:
all-local: $(comp_noinst)
$(OMPI_V_LN_SCOMP) if test -z "$(lib_LTLIBRARIES)"; then \
rm -f "$(comp_inst)"; \
$(LN_S) "$(comp_noinst)" "$(comp_inst)"; \
Expand Down