v3.1.x: pmix2x: add PMIX_EXPORT decoration to mca_psensor_file_component #6057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhc54
approved these changes
Nov 7, 2018
|
@jsquyres Actually, this doesn't need to go to master, since that's tracking upstream PMIx. This is a PR to the v3.1 branch, which uses PMIx 2.1.4. What's interesting is why my build of 3.0.3 doesn't have the same issue, even though it also uses PMIx 2.1.4... EDIT: Sorry, I take that back. 3.0.3 suffers from the same problem. I was looking an already-patched build. I'll PR it to that branch as well, in case you have plans for a 3.0.4. @rhc54 It's missing from the v2.1 branch in pmix, so I just PR the change in there (openpmix/openpmix#931). |
|
Can one of the admins verify this patch? |
benmenadue
changed the title
|
ok to test |
|
bot:mellanox:retest |
…an be found later. Signed-off-by: Ben Menadue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mca_psensor_file_componentneeds to be decorated withPMIX_EXPORTso that it can be found bydlsymwhen opening the component.Refs #6056.