v3.0.x: mpi/c: Fix MPI_TYPE_CREATE_F90_{REAL,COMPLEX} #6195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes edge cases of `r = 38` and `r = 308`. As defined in the MPI standard, `TYPE_CREATE_F90_REAL` and `TYPE_CREATE_F90_COMPLEX` must be consistent with the Fortran `SELECTED_REAL_KIND` function. The `SELECTED_REAL_KIND` function is defined based on the `RANGE` function. The `RANGE` function returns `INT(MIN(LOG10(HUGE(X)), -LOG10(TINY(X))))` for a real value `X`. The old code considers only `INT(LOG10(HUGE(X)))` using `*_MAX_10_EXP`. This commit adds `INT(-LOG10(TINY(X)))` part using `*_MIN_10_EXP`. This bug affected the following `p`-`r` combinations. | p | r | expected | returned | expected | returned | | :------------ | --: | :-------- | :-------- | :------- | :-------- | | MPI_UNDEFINED | 38 | REAL8 | REAL4 | COMPLEX16 | COMPLEX8 | | 0 <= p <= 6 | 38 | REAL8 | REAL4 | COMPLEX16 | COMPLEX8 | | MPI_UNDEFINED | 308 | REAL16 | REAL8 | COMPLEX32 | COMPLEX16 | | 0 <= p <= 15 | 308 | REAL16 | REAL8 | COMPLEX32 | COMPLEX16 | MPICH returns the same result as Open MPI with this fix. Signed-off-by: KAWASHIMA Takahiro <[email protected]> (cherry picked from commit 6fb01f6)
bosilca
approved these changes
Dec 13, 2018
jsquyres
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #6159 to the v3.0.x branch.
@bosilca please review.
This commit fixes edge cases of
r = 38andr = 308.As defined in the MPI standard,
TYPE_CREATE_F90_REALandTYPE_CREATE_F90_COMPLEXmust be consistent with the FortranSELECTED_REAL_KINDfunction. TheSELECTED_REAL_KINDfunction is defined based on theRANGEfunction. TheRANGEfunction returnsINT(MIN(LOG10(HUGE(X)), -LOG10(TINY(X))))for a real valueX.The old code considers only
INT(LOG10(HUGE(X)))using*_MAX_10_EXP. This commit addsINT(-LOG10(TINY(X)))part using*_MIN_10_EXP.This bug affected the following
p-rcombinations.MPICH returns the same result as Open MPI with this fix.
(cherry picked from commit 6fb01f6)