Skip to content

Conversation

@jsquyres
Copy link
Member

@jsquyres jsquyres commented Mar 5, 2019

Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit 8794077)

@bwbarrett This was already merged on master, v3.0.x., and v4.0.x. Looks like we missed v3.1.x.

Did we not remove it from v3.1.x for a reason? Backwards compatibility, maybe? (or is there another PR for this that hasn't been merged yet, and I missed it?)

If we leave it on v3.1.x, we need to clean up some warnings that are appearing in autogen output:

autoreconf: running: automake --add-missing --copy --force-missing --warnings=all,no-obsolete,no-override
configure.ac:1100: warning: MCA_opal_common_ofi_CONFIG is m4_require'd but not m4_defun'd
orte/mca/rml/ofi/configure.m4:22: MCA_orte_rml_ofi_CONFIG is expanded from...
config/opal_mca.m4:577: MCA_CONFIGURE_M4_CONFIG_COMPONENT is expanded from...
config/opal_mca.m4:356: MCA_CONFIGURE_FRAMEWORK is expanded from...
config/opal_mca.m4:256: MCA_CONFIGURE_PROJECT is expanded from...
config/opal_mca.m4:39: OPAL_MCA is expanded from...

Signed-off-by: Ralph Castain <[email protected]>
(cherry picked from commit 8794077)
Copy link
Contributor

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missed it, I imagine - no reason not to remove it.

@bwbarrett
Copy link
Member

I think this was just incompetence on my part that we missed removing in 3.1.

@bwbarrett
Copy link
Member

bot:mellanox:retest

@jsquyres
Copy link
Member Author

FWIW: Mellanox's CI might still be inoperable. They were having problems with it last week, and @artpol84 told me (in person / in Chattanooga) that it might take a few days to fix it.

@jsquyres jsquyres merged commit 10de852 into open-mpi:v3.1.x Mar 12, 2019
@jsquyres jsquyres deleted the pr/v3.1.x/remove-stale-rml-ofi-component branch March 12, 2019 15:21
@ibm-ompi
Copy link

The IBM CI (GNU Compiler) build failed! Please review the log, linked below.

Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants