v4.0.x: Oshmem multiple contexts #6509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomislav Janjusic <[email protected]> (cherry picked from commit 79ba752)
Signed-off-by: Xin Zhao <[email protected]> Signed-off-by: Tomislav Janjusic <[email protected]> (cherry picked from commit 289595e)
Signed-off-by: Tomislav Janjusic <[email protected]> (cherry picked from commit 9a06000)
… track of ucx_ctx_default's rkeys Signed-off-by: Tomislav Janjusic <[email protected]> (cherry picked from commit 48033ac)
brminich
approved these changes
Mar 21, 2019
hoopoepg
approved these changes
Mar 21, 2019
|
This looks like it might be related to #6443. Any advice regarding both of these? |
Signed-off-by: Tomislav Janjusic <[email protected]> (cherry picked from commit e1c1ab0)
Signed-off-by: Tomislav Janjusic <[email protected]> (cherry picked from commit e041400)
…s/delete oshmem_barrier in shmem_ctx_destroy ompi/oshmem/spml/ucx: optimize spml ucx progress Signed-off-by: Tomislav Janjusic <[email protected]> (cherry picked from commit 9c3d00b)
janjust
force-pushed
the
oshmem-multiple-contexts-v4.0.x
branch
from
92babff to
69a80fc
Compare
|
@jsquyres corresponding cherry-picks fixed in this PR also |
|
@jsquyres please re-review (or at least dismiss your earlier change request) when you get a moment. Thanks. |
|
@gpaulsen I'm not qualified to review this one -- it's all about oshmem and UCX. I just made the one comment about superfluous commits + cherry pick hashes. That being said, the corresponding master PR hasn't been merged yet. So this PR still isn't ready. |
|
@gpaulsen sorry this PR missed the train. It can go out in 4.0.2. |
|
@jsquyres PR for master has been merged in so dismissing your review. |
hppritcha
dismissed
jsquyres’s stale review
PR #6492 has been merged into master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked commits from #6492
This PR replaces #6443