v4.0.x: Cleanup race condition in finalize that leads to incomplete vader cleanup #6550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 31, 2019 11:23
See #5798 (comment) for a lengthy explanation Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit 57f6b94)
Functionality moved to PMIx Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit cfdd08d)
|
I think that did the trick. Thanks, Ralph! |
|
@ggouaillardet could you please review? |
|
Intel engineers have verified that this patch fixes the issue. |
ggouaillardet
approved these changes
Apr 5, 2019
|
Just an FYI: the second commit removes stale code that cannot be reached any more as the functionality moved to PMIx. I only included it because the desired commit was based on it - i.e., I would have had to make some significant mods to the desired commit in order to get it to build/work. |
|
@gpaulsen let's merge this. |
This was referenced Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aingerson Please verify this fixes the problem
Fixes #6547