Skip to content

Conversation

@alex-anenkov
Copy link
Contributor

Implements Bruck algorithm for MPI_Iallgather.

Signed-off-by: Alex Anenkov [email protected]

@ompiteam-bot
Copy link

Can one of the admins verify this patch?

@bosilca
Copy link
Member

bosilca commented Apr 8, 2019

ok to test.

@alex-anenkov
Copy link
Contributor Author

bot:ompi:retest

1 similar comment
@jsquyres
Copy link
Member

jsquyres commented Apr 9, 2019

bot:ompi:retest

@jsquyres jsquyres requested a review from bosilca April 9, 2019 14:22
return res;
}

/* allocate temporary buffers */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting ugly. Why can't we have a nice function based init ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, that this approach is ugly, but I adhered overall design of libnbc (allreduce, alltoall, etc). I am ready to fix this PR, but it is required an additional discussion of memory allocation in libnbc.

@awlauria
Copy link
Contributor

Ping - now almost a year old. Any update on this pr?

@awlauria awlauria added this to the v5.0.0 milestone Mar 27, 2020
@awlauria
Copy link
Contributor

Adding this to the 5.0 milestone for tracking. Since this seems more like a feature than a bug fix, if you want it for 5.0 please target getting this into master by the end of April. Thanks.

@gpaulsen
Copy link
Member

@alex-anenkov - How was this tested? Is this safe for v5.0?

@alex-anenkov
Copy link
Contributor Author

Hello @gpaulsen. Two years have passed since the opening of this PR. I'm not involved with OpenMPI development, so I'm not sure if PR is safe for v5.0. I think it will be better if I close it. Thanks.

@gpaulsen
Copy link
Member

gpaulsen commented Feb 3, 2021

@alex-anenkov That's a shame, but thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants