v3.1: make-authors.pl script not compatible with being a submodule. #6623
Conversation
make-authors.pl checks that .git exists and is a directory before getting the git log - but when a repo is checked out as a submodule of a larger repository, .git is not a directory, it's just a text file. This can cause make-authors.pl to terminate inappropriately. Author: Michael Heinz <[email protected]> Signed-off-by: Michael Heinz <[email protected]> (cherry picked from commit 0a8fa54)
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6 |
jsquyres
changed the title
I'm not sure what to do with this - the link takes me to a default landing page rather than a build log? @gpaulsen - can you offer any suggestions? |
|
bot:ibm:xl:retest (it looks like a network issue in the lab - let's try again.) |
|
bot:ibm:xl:retest |
|
The IBM XL CI keeps tripping on a network issue. Given the scope of this PR and that the other IBM CI has passed, I'm ok with merging it in even if the IBM XL CI is marked as failed. I'll keep monitoring the CI machine to try to resolve the network issue. Sorry about that. |
|
bot:ibm:xl:retest |
4 participants
Refs #6614
make-authors.pl checks that .git exists and is a directory before
getting the git log - but when a repo is checked out as a submodule of a
larger repository, .git is not a directory, it's just a text file. This
can cause make-authors.pl to terminate inappropriately.
Author: Michael Heinz [email protected]
Signed-off-by: Michael Heinz [email protected]
(cherry picked from commit 0a8fa54)