Skip to content

Conversation

@yosefe
Copy link
Contributor

@yosefe yosefe commented May 12, 2019

  • added multiple segments processing
  • added shmemx_malloc_with_hint call + set of hints

(picked from master 94b5e91)

- added multiple segments processing
- added shmemx_malloc_with_hint call + set of hints

(picked from master 94b5e91)

Signed-off-by: Sergey Oblomov <[email protected]>
Signed-off-by: Yossi Itigin <[email protected]>
@yosefe yosefe added this to the v4.0.2 milestone May 12, 2019
@hppritcha
Copy link
Member

@yosefe please correct sign off problem with commit
2b2a413

- removed dead code

(cherry picked from master 4df8c1b)

Signed-off-by: Sergey Oblomov <[email protected]>
Signed-off-by: Yossi Itigin <[email protected]>
@yosefe yosefe force-pushed the topic/alloc-with-hint-impl-master-v4.0.x branch from 8085ce9 to e6cb5b0 Compare May 13, 2019 13:39
@yosefe
Copy link
Contributor Author

yosefe commented May 13, 2019

@hppritcha thanks, fixed

@hppritcha
Copy link
Member

this was discussed on the devel call today. the consensus is that we normally do not take this type of addition into a release branch.

@yosefe yosefe force-pushed the topic/alloc-with-hint-impl-master-v4.0.x branch from 3cedefc to fbd6798 Compare May 15, 2019 14:11
@gpaulsen
Copy link
Member

Howard and I discussed today, and agreed to take this as an experimental extension to OSHMEM, but wanted to relay the following comments:

Typically we don't accept new functionality into a release branch, but our thoughts are as following:

  1. This is an extension to OSHMEM, which reduces risk to existing OSHMEM users.
  2. This is isolated only to the OSHMEM component, and doesn't impact any Open MPI, reduces risk to majority of users.
  3. This passes OSHMEM CI regression, that also reduces risk.

Given it's importance, we understand and will take it. We don't want this to start a precedence of accepting new functionality on release branches. We hope to keep the release branches as stable and minimal as possible, which means keeping them to bugfixes only.

Finally, we noticed there isn't much OSHMEM in MTT, it would be nice to have some specific OSHMEM tests in MTT.

@gpaulsen gpaulsen merged commit c22326e into open-mpi:v4.0.x May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants