Skip to content

Conversation

@esil
Copy link

@esil esil commented Jun 25, 2015

04e30d4 commit adds support for auto-detecting install dir for open-mpi. If path specified at build time does not exist then openmpi uses path relative to executable.

04e30d4 adds support for ${} variables in paths to compiler in config files. With that patch we can set path to compiler relative to open-mpi install dir.

@rhc54 rhc54 modified the milestones: Future, Open MPI 2.X Jun 25, 2015
@mellanox-github
Copy link

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/667/

@jsquyres
Copy link
Member

@esil It feels like this type of functionality should really be in a component -- not added in the base. I.e., you added some very specific functionality into the generic base, rather than creating a new plugin for that specific type of functionality.

Can you move this functionality off into a new component?

@jsquyres
Copy link
Member

jsquyres commented Jul 7, 2015

@esil Per my above comment, do you think you'll be moving this functionality into its own component?

@jsquyres
Copy link
Member

@esil I haven't heard back from you. Closing this PR; feel free to re-open it if you can update the code per prior suggestions. Thanks.

@jsquyres jsquyres closed this Aug 15, 2015
@pathscale
Copy link

We are not 100% familiar with OpenMPI build infrastructure. Can you reference an example of something doing something similar to what you proposed? Did the patch cause build failures? I feel pretty strongly that this is a core feature which is missing. My vote probably doesn't mean much, if anything though.

@jsquyres
Copy link
Member

I'm just suggesting to put this in a (probably new) installdirs component (vs. the installdirs base).

jsquyres pushed a commit to jsquyres/ompi that referenced this pull request Nov 10, 2015
…pi-f08-mpi-aint

v2.x: Fortran: add missing MPI_AINT in mpi_f08 module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants